From 17b8365d917c6e082bb1c4862b0f55fc8ee9c0b9 Mon Sep 17 00:00:00 2001 From: Sebastian Eckweiler Date: Fri, 23 Jun 2023 10:34:51 +0200 Subject: [PATCH 1/3] fix proxy connection pool creation Signed-off-by: Sebastian Eckweiler --- src/databricks/sql/auth/thrift_http_client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/databricks/sql/auth/thrift_http_client.py b/src/databricks/sql/auth/thrift_http_client.py index 89ad66a0..3e6e9662 100644 --- a/src/databricks/sql/auth/thrift_http_client.py +++ b/src/databricks/sql/auth/thrift_http_client.py @@ -109,7 +109,7 @@ def open(self): headers={"Proxy-Authorization": self.proxy_auth}, ) self.__pool = proxy_manager.connection_from_host( - self.host, self.port, pool_kwargs=_pool_kwargs + self.realhost, self.realport, pool_kwargs=_pool_kwargs, scheme=self.scheme ) else: self.__pool = pool_class(self.host, self.port, **_pool_kwargs) From e5e4618617d3e03f4ac570e81de8d77a40d494f0 Mon Sep 17 00:00:00 2001 From: Sebastian Eckweiler Date: Fri, 23 Jun 2023 15:24:20 +0200 Subject: [PATCH 2/3] black'd Signed-off-by: Sebastian Eckweiler --- src/databricks/sql/auth/thrift_http_client.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/databricks/sql/auth/thrift_http_client.py b/src/databricks/sql/auth/thrift_http_client.py index 3e6e9662..fbae1cc2 100644 --- a/src/databricks/sql/auth/thrift_http_client.py +++ b/src/databricks/sql/auth/thrift_http_client.py @@ -109,7 +109,10 @@ def open(self): headers={"Proxy-Authorization": self.proxy_auth}, ) self.__pool = proxy_manager.connection_from_host( - self.realhost, self.realport, pool_kwargs=_pool_kwargs, scheme=self.scheme + host=self.realhost, + port=self.realport, + scheme=self.scheme, + pool_kwargs=_pool_kwargs, ) else: self.__pool = pool_class(self.host, self.port, **_pool_kwargs) From f90b1853fcadb438fe24b5d6a8bb88d9ce7dfbea Mon Sep 17 00:00:00 2001 From: Jesse Whitehouse Date: Tue, 11 Jul 2023 19:33:19 -0500 Subject: [PATCH 3/3] Update changelog Signed-off-by: Jesse Whitehouse --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 961423ad..8be708c9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Add support for Cloud Fetch - Fix: Revised SQLAlchemy dialect and examples for compatibility with SQLAlchemy==1.3.x - Fix: oauth would fail if expired credentials appeared in ~/.netrc +- Fix: Python HTTP proxies were broken after switch to urllib3 ## 2.7.0 (2023-06-26)