From 0f85446def4384ff10afc3d9d2b34ebcf8978853 Mon Sep 17 00:00:00 2001 From: Ilia Babanov Date: Tue, 6 Feb 2024 18:45:50 +0100 Subject: [PATCH] Fix deeplinks format to work across all clouds (#1044) Tested on native databricks, azure, gcp, and aws. Pipeline links seem to work fine too, as they already use "hash" links --- .../src/ui/bundle-resource-explorer/JobTreeNode.ts | 2 +- .../src/ui/bundle-resource-explorer/TaskRunStatusTreeNode.ts | 2 +- .../src/ui/bundle-resource-explorer/TaskTreeNode.ts | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/databricks-vscode/src/ui/bundle-resource-explorer/JobTreeNode.ts b/packages/databricks-vscode/src/ui/bundle-resource-explorer/JobTreeNode.ts index f4494de2d..801c535e7 100644 --- a/packages/databricks-vscode/src/ui/bundle-resource-explorer/JobTreeNode.ts +++ b/packages/databricks-vscode/src/ui/bundle-resource-explorer/JobTreeNode.ts @@ -22,7 +22,7 @@ export class JobTreeNode implements BundleResourceExplorerTreeNode { return undefined; } - return `${host.toString()}jobs/${this.data.id}`; + return `${host.toString()}#job/${this.data.id}`; } constructor( diff --git a/packages/databricks-vscode/src/ui/bundle-resource-explorer/TaskRunStatusTreeNode.ts b/packages/databricks-vscode/src/ui/bundle-resource-explorer/TaskRunStatusTreeNode.ts index c882441fa..b3532e844 100644 --- a/packages/databricks-vscode/src/ui/bundle-resource-explorer/TaskRunStatusTreeNode.ts +++ b/packages/databricks-vscode/src/ui/bundle-resource-explorer/TaskRunStatusTreeNode.ts @@ -24,7 +24,7 @@ export class TaskRunStatusTreeNode implements BundleResourceExplorerTreeNode { return undefined; } - return `${host.toString()}jobs/${this.jobId}/runs/${ + return `${host.toString()}#job/${this.jobId}/run/${ this.runDetails.run_id }`; } diff --git a/packages/databricks-vscode/src/ui/bundle-resource-explorer/TaskTreeNode.ts b/packages/databricks-vscode/src/ui/bundle-resource-explorer/TaskTreeNode.ts index 5fc717d5d..42bcf9f38 100644 --- a/packages/databricks-vscode/src/ui/bundle-resource-explorer/TaskTreeNode.ts +++ b/packages/databricks-vscode/src/ui/bundle-resource-explorer/TaskTreeNode.ts @@ -33,7 +33,9 @@ export class TaskTreeNode implements BundleResourceExplorerTreeNode { return undefined; } - return `${host.toString()}jobs/${this.jobId}/tasks/${this.taskKey}`; + return `${host.toString()}#job/${this.jobId}/tasks/task/${ + this.taskKey + }`; } constructor( private readonly context: ExtensionContext,