Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Virtual environment required but not clearly communicated #1357

Open
dustinvannoy-db opened this issue Sep 14, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@dustinvannoy-db
Copy link

Describe the bug
Virtual environment is required for extension to be fully usable. Not opposed to forcing use of virtual environment but it isn't clear that is the issue. It feels like it just isn't finding the interpreter that has been selected rather than acknowledging that it is not compatible with using the extension.

To Reproduce
Steps to reproduce the behavior:

  1. Open folder without databricks.yml or virtual environment
  2. Click on 'Migrate current folder to a Databricks Project'
  3. Configure profile.
  4. Set interpreter from Command Pallet to a system installed interpreter (Cmd + Shift + P) -> Python: Select Interpreter ->
  5. Open python file to confirm interpreter in bottom right info.
  6. Try to install databricks-connect from extensions doesn't provide any feedback.
  7. Click on "Python Environment -> Activate an environment ..." only gives environment type option of Venv or Conda
  8. "Run File as workflow" still works.
  9. "Run current file with Databricks Connect" opens up the selection for environment type.
  10. Also, the extension doesn't recognize the interpreter so it looks like nothing is configured.

Screenshots
If applicable, add screenshots to help explain your problem.
image
image
image

System information:

Paste the output ot the Help: About command (CMD-Shift-P).
Version: 1.93.0 (Universal)
Commit: 4849ca9bdf9666755eb463db297b69e5385090e3
Date: 2024-09-04T13:02:38.431Z (1 wk ago)
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0

Databricks Extension Version
2.4.2

Databricks Extension Logs
Please attach the databricks extension logs

Additional context
Add any other context about the problem here.

@dustinvannoy-db dustinvannoy-db added the bug Something isn't working label Sep 14, 2024
@ilia-db
Copy link
Contributor

ilia-db commented Oct 24, 2024

In the 2.4.7 we've reworked the "Python Environment" panel a little. Virtual environment is still required for the databricks connect, but now we don't enforce python versions to match DBR requirements (but will show a warning if they don't match).

We still use the same quick-pick UI from the python extension for the environment selection. So "Activate an environment ..." action leads to "Select Interpreter" UI, which might be confusing indeed. I'll leave this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants