Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negative values from numpy.random.normal #24

Open
sastoudt opened this issue Aug 27, 2019 · 1 comment
Open

negative values from numpy.random.normal #24

sastoudt opened this issue Aug 27, 2019 · 1 comment

Comments

@sastoudt
Copy link
Contributor

For smaller values or with large margins of error, the numpy.random.normal in approximate_mean may return a negative number which won't make sense in context. We should probably just use max(0, simulated_value) instead.
@sastoudt sastoudt mentioned this issue Aug 27, 2019
Open
@sastoudt
Copy link
Contributor Author

addressed in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sastoudt