Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Bootstrap build setup to the Django and Wagtail templates #308

Open
Tracked by #326
hancush opened this issue Jan 19, 2023 · 9 comments
Open
Tracked by #326
Assignees

Comments

@hancush
Copy link
Member

hancush commented Jan 19, 2023

Documentation request

It's easy to use Sass to customize the look and feel of Bootstrap, but it's not always easy to set up. Bake scaffolding into our templates, including a custom Sass file, develop script, and README instructions.

Example PRs:

@smcalilly
Copy link
Contributor

@fatima3558 i'm going to update bootstrap via #278, will that cause any problems with this work?

@hancush
Copy link
Member Author

hancush commented Feb 23, 2023

@smcalilly Bootstrap 5 is not compatible with IE. Think we want to stick with 4.

@smcalilly
Copy link
Contributor

@hancush Do we still need to support IE? They retired it last summer and started removing it from existing Windows 10 distros.

@smcalilly
Copy link
Contributor

I'm curious about the access to technology and equity ramifications that we'd incur by not supporting IE, that's the only reason I can think of where we'd need to continue that support. Maybe we can look at Google Analytics data for some of our sites to see if it's still used.

@hancush
Copy link
Member Author

hancush commented Feb 23, 2023

Good point. We had a whopping 3 visits to ChiBlockBuilder from IE since we set up Matomo. Paging @derekeder on this, as well. In the past, I've defended IE because of our government clients, who tend to have less control over the browsers available to them on their work machines. Do we still need to support it in 2023?

@smcalilly
Copy link
Contributor

Yeah I've felt the same way about IE even though it's difficult from a developer perspective. When I saw that news about them disabling it, I thought that was a signal that we no longer had to support it but haven't done much research about it.

This blog post argues that it might be good for accessibility: https://www.hassellinclusion.com/blog/should-accessible-websites-still-support-ie11/. I don't know if it's out of date, there's no publication date but there are comments from January 2021 so it's possible the information is still valid.

@fgomez828
Copy link
Contributor

per the notice at the top of the Micorosoft FAQ on this topic this page, it sounds like we might be able to stop supporting IE this summer? I'm not 100% sure what other considerations there are besides general availability of the app on Windows.

Here's the highlighted text at the top of the page:

Update:
The retired, out-of-support Internet Explorer 11 desktop application has been permanently disabled through a Microsoft Edge update on certain versions of Windows 10.

IE11 visual references, such as the IE11 icons on the Start Menu and taskbar,
will be removed by the June 2023 Windows security update (“B” release) scheduled for June 13, 2023.

@smcalilly
Copy link
Contributor

@fatima3558 is making good progress on this.

@smcalilly
Copy link
Contributor

See: https://gs.statcounter.com/browser-market-share/all/united-states-of-america

IE has 0.24% of market share in March 2023.

We're okay with upgrading to Bootstrap 5.

IE support could be something we decide upon with a client beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants