New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change _cid to _hash #95

Open

waynewyang opened this issue Aug 30, 2023 · 0 comments

Labels

bug

Member

waynewyang commented Aug 30, 2023

We actually store the hash values of leaf nodes, not CIDs. So, for function parameters similar to the following, '_cid' should be changed to '_hash'.
https://github.com/dataswap/core/blob/main/src/v0.8/interfaces/core/ICarstore.sol#L48

waynewyang added the bug label

Kennynauh added this to the Integration Testing and Exception Testing milestone

lovel8 self-assigned this

siriusyim removed this from the Integration Testing and Exception Testing milestone

siriusyim unassigned lovel8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment