Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows DPI v2 #127

Open
learn-more opened this issue Sep 17, 2020 · 1 comment
Open

Windows DPI v2 #127

learn-more opened this issue Sep 17, 2020 · 1 comment

Comments

@learn-more
Copy link

Hello,

First of all, thanks for your efforts to add support for WinXP / ReactOS :)

Regarding your djDYNAMICALLY_BIND_SETPROCESSDPIAWARE code:
This is nothing to be nervous about!
GetProcAddress is very well documented, and will return NULL (0) when the function is not present.
Your function prototype (typedef int (WINAPI *PFN)();) is almost correct (but not incorrect in a way that it will break anthing, just the return value is different, which you don't check anyway).

Here is an article describing the manifest way of doing this, and even doing it per-monitor (in a way that has a gracious fallback to not doing anything on Windows XP / ReactOS)
https://building.enlyze.com/posts/writing-win32-apps-like-its-2020-part-3/#declaring-dpi-awareness

Regards,

Mark.

@davidjoffe
Copy link
Owner

davidjoffe commented Nov 20, 2022

Thank you! And thanks for ReactOS, I am a fan .. have seen these manifests for DPI but have never looked closely at trying them ... will try have a look sometime.

I've used this dynamic DLL loading methods many times but felt a bit funny/unsure using it this way this time .. but reassuring to hear ... am hoping the latest 1.0.3 release works on ReactOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants