Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log.Fatal #71

Closed
friesencr opened this issue Aug 3, 2023 · 1 comment · Fixed by #72
Closed

Don't log.Fatal #71

friesencr opened this issue Aug 3, 2023 · 1 comment · Fixed by #72

Comments

@friesencr
Copy link

A library shouldn't os.Exit on error which log.Fatal is doing. We are bouncing workers because of this.

@DamienDeepgram
Copy link
Contributor

Opened a PR to move from log.Fatal -> log.Panic

#72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants