Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using root log instead of logger #384

Closed
kiinami opened this issue Aug 17, 2023 · 3 comments · Fixed by #385
Closed

Using root log instead of logger #384

kiinami opened this issue Aug 17, 2023 · 3 comments · Fixed by #385

Comments

@kiinami
Copy link
Contributor

kiinami commented Aug 17, 2023

svglib/svglib/svglib.py

Line 656 in 7742244

logging.error("Unsupported shape type %s for clipping", shape.__class__.__name__)

When this error is triggered, the log is published to the root logger, instead of to the module logger.
@github-actions
Copy link

Thank you for raising your first issue! Your help to improve svglib is much appreciated!

@claudep
Copy link
Collaborator

claudep commented Aug 17, 2023

Well found, would you like to suggest a pull request?

@kiinami
Copy link
Contributor Author

kiinami commented Aug 17, 2023

Yes, on it

@kiinami kiinami mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: using dedicated logger instead of root logger
2 participants
@claudep @kiinami