-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svglib doesn't remove temporary files properly? #393
Comments
Thank you for raising your first issue! Your help to improve svglib is much appreciated! |
It's totally possible the file is never removed. Any implementation suggestion is welcome. |
I think instead of creating a temporary file here https://github.com/deeplook/svglib/blob/main/svglib/svglib.py#L695, maybe it can create a |
Any pull request is welcome! |
Fixed by 484d366 |
When using svglib on svgs that have images, we found the disk size keeps growing up. The culprit is the temporary files created by this method
xlink_href_target
.This line https://github.com/deeplook/svglib/blob/main/svglib/svglib.py#L701 mentioned the temporary files needs to be removed later, but I didn't find the place where they got removed.
Did I miss something or the removal is really missing?
The text was updated successfully, but these errors were encountered: