Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Validate mis-match result reporting #399

Closed
2 tasks
meganwolf0 opened this issue Apr 30, 2024 · 0 comments · Fixed by #400
Closed
2 tasks

Dev Validate mis-match result reporting #399

meganwolf0 opened this issue Apr 30, 2024 · 0 comments · Fixed by #400
Assignees
Labels
bug Something isn't working triage Awaiting triage from the team

Comments

@meganwolf0
Copy link
Collaborator

Environment

Device and OS:
App version:
Kubernetes distro:
Kubernetes version:
provider:

  • kyverno
  • opa

Steps to reproduce

When you pass empty resources, expected case would be to return a false evaluation but instead is true

Expected result

Actual Result

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

Additional Context

Basically, this block in validation handles the case correctly:

// Individual result state
if lulaValidation.Result.Passing > 0 && lulaValidation.Result.Failing <= 0 {
	lulaValidation.Result.State = "satisfied"
} else {
	lulaValidation.Result.State = "not-satisfied"
}

but in dev validate, only zero failing results are verified, so 0 passing needs to get captured as a "not-satisfied" or false return.

@meganwolf0 meganwolf0 added the bug Something isn't working label Apr 30, 2024
@meganwolf0 meganwolf0 self-assigned this Apr 30, 2024
@github-actions github-actions bot added the triage Awaiting triage from the team label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Awaiting triage from the team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant