Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: use go-getter/v2 for filedownloads #693

Open
mildwonkey opened this issue Sep 30, 2024 · 0 comments
Open

Feature Request: use go-getter/v2 for filedownloads #693

mildwonkey opened this issue Sep 30, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mildwonkey
Copy link
Contributor

Using go-getter as the implementation of network.Fetch allows downloading local and network files, as well as a number of other network protocols. It also handles credentials for things like git and s3 downloads.

Things to consider: go-getter will download zipped archives and directories, not just files (though we can use GetFile vs. GetAny anywhere we want/need to control that - especially for the initial implementation let's not change the behavior for any pre-existing fetching, but I want this in the files domain), so code that assumes there's a 1-1 relationship between the filepath and the files downloaded likely needs to walk the downloaded filepath to get the list of files in the directory.

@mildwonkey mildwonkey added the enhancement New feature or request label Sep 30, 2024
@github-actions github-actions bot added the triage Awaiting triage from the team label Sep 30, 2024
@brandtkeller brandtkeller added this to the Aligned Capabilities milestone Oct 9, 2024
@brandtkeller brandtkeller removed the triage Awaiting triage from the team label Oct 9, 2024
@mildwonkey mildwonkey self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

2 participants