Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor rbac.test.ts #1329

Open
schaeferka opened this issue Oct 24, 2024 · 0 comments
Open

chore: refactor rbac.test.ts #1329

schaeferka opened this issue Oct 24, 2024 · 0 comments

Comments

@schaeferka
Copy link
Contributor

Describe what should be investigated or refactored

The CapabilityExport[] objects in rbac.test.ts seemsto be re-used by a couple of tests. To be more direct about which keys we are toggling for particular test cases, maybe we should have some sort of generator or a defaultCapabilityExport that we use as a starting point. Then, in each test case, the "Arrange" step involves setting the key(s) that are relevant to the particular test case.

The same idea goes for a lot of the "expected" JSON data

Links to any relevant code

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant