You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what should be investigated or refactored
The CapabilityExport[] objects in rbac.test.ts seemsto be re-used by a couple of tests. To be more direct about which keys we are toggling for particular test cases, maybe we should have some sort of generator or a defaultCapabilityExport that we use as a starting point. Then, in each test case, the "Arrange" step involves setting the key(s) that are relevant to the particular test case.
The same idea goes for a lot of the "expected" JSON data
Links to any relevant code
Additional context
The text was updated successfully, but these errors were encountered:
Describe what should be investigated or refactored
The CapabilityExport[] objects in
rbac.test.ts
seemsto be re-used by a couple of tests. To be more direct about which keys we are toggling for particular test cases, maybe we should have some sort of generator or a defaultCapabilityExport that we use as a starting point. Then, in each test case, the "Arrange" step involves setting the key(s) that are relevant to the particular test case.The same idea goes for a lot of the "expected" JSON data
Links to any relevant code
Additional context
The text was updated successfully, but these errors were encountered: