Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose configuration for Store debounceBackoff #1343

Open
rjferguson21 opened this issue Oct 28, 2024 · 1 comment
Open

Expose configuration for Store debounceBackoff #1343

rjferguson21 opened this issue Oct 28, 2024 · 1 comment
Labels
enhancement New feature or request ON-HOLD Needs investigation uds Tracked by UDS project. Adds to UDS Inbox when applied.

Comments

@rjferguson21
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When interacting with the Pepr store and using functions like Store.setItemAndWait or Store.removeItemAndWait the total time between function call and awaited return can be up to 10 seconds (5 seconds for flush, 5 seconds for watch) based on on the default debounce configuration for the store.

Ideally this would be configurable to adjust based on the usage of the store.

Describe the solution you'd like

  • Given A Pepr Module
  • When And environment variable named PEPR_STORE_DEBOUNCE_DELAY is set to 2000
  • Then The Pepr store uses 2000 for the internal debounce delay.

Describe alternatives you've considered

We could potentially expose two configuration values, one for the watch delay and one for the cache flush delay but I don't have strong feelings about that being the case.

Additional context

We are using Store.removeItemAndWait in our WIP finalizer which results in a long blocking delay before the resource is removed. I'm a bit on the fence if we should re-evaluate our own usage and switch to the non-blocking call but I think it is still something we'd like to configure regardless.

@rjferguson21 rjferguson21 added the enhancement New feature or request label Oct 28, 2024
@cmwylie19 cmwylie19 added this to the v0.39.0 milestone Oct 28, 2024
@cmwylie19 cmwylie19 added the uds Tracked by UDS project. Adds to UDS Inbox when applied. label Oct 28, 2024
@cmwylie19
Copy link
Collaborator

I am going to put this one on hold. @jeff-mccoy asked us to look into backing the store with sqlite or valkey before lowering the current bounds.

@cmwylie19 cmwylie19 removed this from the v0.39.0 milestone Nov 4, 2024
@cmwylie19 cmwylie19 added the ON-HOLD Needs investigation label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ON-HOLD Needs investigation uds Tracked by UDS project. Adds to UDS Inbox when applied.
Projects
Status: No status
Development

No branches or pull requests

2 participants