Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor complex implementation in validate-processor.ts #1381

Open
samayer12 opened this issue Nov 4, 2024 · 2 comments · May be fixed by #1382
Open

Refactor complex implementation in validate-processor.ts #1381

samayer12 opened this issue Nov 4, 2024 · 2 comments · May be fixed by #1382
Milestone

Comments

@samayer12
Copy link
Collaborator

Describe what should be investigated or refactored

Resolve the following linter warning:
15:8 warning Async function 'validateProcessor' has a complexity of 13. Maximum allowed is 10 complexity

Links to any relevant code

Check out src/lib/validate-processor.ts

Additional context

Related to #1248

@samayer12 samayer12 self-assigned this Nov 4, 2024
@samayer12 samayer12 added this to the v0.39.0 milestone Nov 4, 2024
@samayer12 samayer12 linked a pull request Nov 4, 2024 that will close this issue
5 tasks
@samayer12
Copy link
Collaborator Author

validate-processor.ts is largely untested on main. We'll want to back-fill with some unit tests so that we can confidently refactor. This will provide a faster feedback loop instead of waiting for E2E tests to run.

File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
validate-processor.ts |   14.28 |        0 |       0 |   14.28 | 22-85

@samayer12 samayer12 removed their assignment Nov 6, 2024
@samayer12
Copy link
Collaborator Author

Unstarting this track of work in favor of v0.40.0 milestones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

1 participant