Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prune command #904

Open
UncleGedd opened this issue Sep 5, 2024 · 3 comments
Open

Add prune command #904

UncleGedd opened this issue Sep 5, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@UncleGedd
Copy link
Collaborator

UncleGedd commented Sep 5, 2024

Is your feature request related to a problem? Please describe

In accordance with our state design doc, add a uds prune command to remove unreferenced packages

Describe the solution you'd like

  • Given unreferenced packages exist in bundle state
  • When uds prune is ran
  • Then unreferenced packages are removed

Additional Reqs

  • Add a --confirm flag, if the user doesn't set it, then prompt
  • The arg to uds prune should be a uds-bundle.yaml, a local bundle ref, or a remote bundle ref
  • If no arg provided, look through all uds-bundle-<name> state secrets in the cluster (be sure to update prompt to support this)
@UncleGedd UncleGedd added the enhancement New feature or request label Sep 5, 2024
@UncleGedd UncleGedd added this to the v0.16.0 milestone Sep 5, 2024
@decleaver
Copy link
Collaborator

would be nice to list packages being pruned before hand?

@UncleGedd
Copy link
Collaborator Author

would be nice to list packages being pruned before hand?

For sure, I tried to capture that on the first additional req. We should def have a prompt that shows the packages to be pruned

@MxNxPx
Copy link

MxNxPx commented Sep 5, 2024

would be nice to list packages being pruned before hand?

For sure, I tried to capture that on the first additional req. We should def have a prompt that shows the packages to be pruned

i like @decleaver 's idea to get a list of what would get pruned. thinking of possible uses to extend things with something like a --dry-run flag. i envision being useful to do something like uds deploy *.zst --prune --dry-run and getting some form of output that displays what current versions of packages are getting updated to some new versions along with packages that would be pruned. if it makes more sense, i could create a separate github issue.

@UncleGedd UncleGedd removed this from the v0.16.0 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants