From fad63846a9cd36d6b0f8b0a01892218e62337147 Mon Sep 17 00:00:00 2001 From: Micah Nagel Date: Tue, 24 Sep 2024 15:52:14 -0600 Subject: [PATCH] fix: eks iac issues, document storage class pre-reqs (#812) EBS impose a 1Gi size limitation on restored PVCs. This adds a short note to pre-reqs about checking CSI limitations. While testing with our EKS IAC I also discovered a few other issues: - IRSA annotations were not correct - Config did not properly variablize region - Config had an unmatched `"` around one of the values - Gitignore did not exclude terraform/tfstate files that shouldn't be committed Fixes https://github.com/defenseunicorns/uds-core/issues/718 - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed --- .github/bundles/rke2/uds-bundle.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/bundles/rke2/uds-bundle.yaml b/.github/bundles/rke2/uds-bundle.yaml index 1e2d1e214..8298a0dc6 100644 --- a/.github/bundles/rke2/uds-bundle.yaml +++ b/.github/bundles/rke2/uds-bundle.yaml @@ -51,7 +51,7 @@ packages: path: credentials.useSecret - name: VELERO_IRSA_ROLE_ARN description: "IRSA ARN annotation to use for Velero" - path: serviceAccount.server.annotations.irsa/role-arn + path: serviceAccount.server.annotations.eks\.amazonaws\.com/role-arn loki: loki: values: @@ -78,4 +78,4 @@ packages: path: loki.storage.s3.region - name: LOKI_IRSA_ROLE_ARN description: "The irsa role annotation" - path: serviceAccount.annotations.irsa/role-arn + path: serviceAccount.annotations.eks\.amazonaws\.com/role-arn