Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoteCidr generated policy should only include except if in the range #950

Open
mjnagel opened this issue Oct 22, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Oct 22, 2024

https://github.com/defenseunicorns/uds-core/blob/2f63db2f26cb30c056f376b1823f758cd403aefe/src/pepr/operator/controllers/network/generators/remoteCidr.ts

Our current remoteCidr policies will unconditionally add the except block with the cloud metadata IP. We should either:

  1. Conditional add it: based on whether it is included in the cidr we put in the policy, this would require determining if the CIDR includes it.
  2. Never include it: Just drop that entirely, simpler but would allow someone to set this to 0.0.0.0/0 or another similar range that includes metadata.

Historically I have encountered issues when except IPs/CIDRs are not contained in the range. I haven't identified any upstream docs or issues related to this but could search for those if required.

@mjnagel mjnagel added possible-bug Something may not be working bug Something isn't working and removed possible-bug Something may not be working labels Oct 22, 2024
@rjferguson21 rjferguson21 added this to the 0.31.0 milestone Oct 25, 2024
@UnicornChance UnicornChance self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants