Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include postgres operator as optional component #53

Open
rjferguson21 opened this issue Mar 11, 2024 · 2 comments
Open

Include postgres operator as optional component #53

rjferguson21 opened this issue Mar 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@rjferguson21
Copy link
Contributor

For testing components that require a Postgres database it would be nice to just include the operator as an optional component

@rjferguson21 rjferguson21 added the enhancement New feature or request label Mar 11, 2024
@mjnagel
Copy link
Contributor

mjnagel commented Mar 27, 2024

I think this would make sense to add as optional. It might also make a lot of sense to switch minio to optional at the same time - in a lot of dev/CI environments it's probably just extra bloat that isn't used (ex: most uds-core single pkg tests)?

@zachariahmiller
Copy link
Contributor

Minio is definitely extra bloat. The postgres operator would be as well. The only issue i see with this approach though is that if either are included in this package specifically it cant be done in a way that properly integrates with istio, which makes testing against the minio or postgres not representative of what it would be in a real environment. If they were being exposed public to the cluster it would mimic and external resource, but not sure what the desire is for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants