Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debug mode option #73

Open
eddiezane opened this issue Apr 27, 2024 · 5 comments
Open

Add a debug mode option #73

eddiezane opened this issue Apr 27, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@eddiezane
Copy link
Member

eddiezane commented Apr 27, 2024

Is your feature request related to a problem? Please describe.

While attempting to debug something in Pepr+UDS, I needed to pass some extra k3s args to enable debug logging and such. An idea from @jeff-mccoy is to add a "debug mode".

Describe the solution you'd like

An arg (or some other control) I can set to enable extra flags for k3s. i.e.

--set K3D_DEBUG=true

The flags I used in this scenario were the following but we could explore others to cut down on the flag passing from the CLI.

uds deploy k3d-core-demo:0.20.0 --set K3D_EXTRA_ARGS="--k3s-arg --kubelet-arg=container-log-max-files=10@server:0 --k3s-arg --kubelet-arg=container-log-max-size=100Mi@server:0 --k3s-arg --debug@server:0"
@eddiezane eddiezane added the enhancement New feature or request label Apr 27, 2024
@eddiezane
Copy link
Member Author

eddiezane commented Apr 27, 2024

--set K3D_EXTRA_ARGS='--k3s-arg --kube-apiserver-arg=--min-request-timeout=120@server:*

@eddiezane
Copy link
Member Author

@zachariahmiller
Copy link
Contributor

@eddiezane This is currently already possible

- name: K3D_EXTRA_ARGS

https://github.com/defenseunicorns/uds-k3d?tab=readme-ov-file#additional-info

@eddiezane
Copy link
Member Author

@zachariahmiller ah sorry for not being more clear. The ask here was to specifically add a meta option to enable all the debug flags you might need when attempting to debug issues such as turning on api server logs, etc so you don't have to look up all the flags and pass them manually.

Does that make sense?

@zachariahmiller
Copy link
Contributor

@eddiezane Yeah that makes sense. I was on the fence when reading the issue for some reason as to whether that was your ask vs just the ability to provide options. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants