Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify scripts to test FFI c code #427

Open
OussamaSaoudi-db opened this issue Oct 24, 2024 · 0 comments
Open

Unify scripts to test FFI c code #427

OussamaSaoudi-db opened this issue Oct 24, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@OussamaSaoudi-db
Copy link
Collaborator

Please describe why this is necessary.

Currently, both the visit-expression and read-table ffi tests use two identical scripts for comparing test results. This is unnecessary code duplication.

Describe the functionality you are proposing.

Unify the scripts into a single one, and make both tests use that one.

Additional context

The testing code can be found in ffi/examples/read-table and ffi/examples/visit-expression.

The scripts can be found in ffi/tests/read-table-testing/run_test.sh and ffi/tests/test_expression_visitor/run_test.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

1 participant