From 7644d0e44968c9958bfb2ef37ec0e8558b3de6e4 Mon Sep 17 00:00:00 2001 From: Matthew Thornton Date: Tue, 18 Jul 2023 11:33:08 -0400 Subject: [PATCH 1/3] PR Template Fixes --- PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 6718602ffb2..146271f7e63 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -Resolves #{jira issue link} +Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description Please explain the changes you made here. @@ -19,7 +19,7 @@ Please explain the changes you made here. ---|--- ## Storybook Story -*For Frontend (Presentationa) Components* +*For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component From 1b13fe0706b77f1ca6fa622b7bd626f303097805 Mon Sep 17 00:00:00 2001 From: Matthew Thornton Date: Tue, 18 Jul 2023 12:24:29 -0400 Subject: [PATCH 2/3] Add a comment --- PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 146271f7e63..d8c8653b73b 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,3 +1,4 @@ + Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description From e169121e3afb81c0d298dbcf4214f272f1ade625 Mon Sep 17 00:00:00 2001 From: Matthew Thornton Date: Tue, 18 Jul 2023 12:26:22 -0400 Subject: [PATCH 3/3] Add another comment --- PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index d8c8653b73b..618e6e5529d 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -8,7 +8,8 @@ Please explain the changes you made here. - [ ] Code compiles correctly ## Testing Plan -1. Go to #{jira issue link} or list them below + +1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT?