From 7d3b19cc81a840001133b20fd0dbf55bc88b34b2 Mon Sep 17 00:00:00 2001
From: Christopher Detlef <>
Date: Tue, 21 May 2024 11:57:34 -0400
Subject: [PATCH] Minor fixes

---
 db/seeds/demo_ama_aod_hearing_data.rb     | 2 +-
 db/seeds/demo_ama_non_aod_hearing_data.rb | 2 +-
 db/seeds/demo_direct_reviews_data.rb      | 4 +++-
 db/seeds/demo_legacy_cases_data.rb        | 2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/db/seeds/demo_ama_aod_hearing_data.rb b/db/seeds/demo_ama_aod_hearing_data.rb
index 718169f9fbb..3e3c7b4679b 100644
--- a/db/seeds/demo_ama_aod_hearing_data.rb
+++ b/db/seeds/demo_ama_aod_hearing_data.rb
@@ -46,7 +46,7 @@ def random_demo_file_number_and_participant_id
     end
 
     def find_or_create_demo_seed_judge(judge_ccs_id)
-      unless judge_ccs_id.empty?
+      unless judge_ccs_id.nil?
         User.find_by_css_id(judge_ccs_id) ||
           create(:user, :judge, :with_vacols_judge_record, css_id: judge_ccs_id, full_name: "Demo Judge " + judge_ccs_id)
       else
diff --git a/db/seeds/demo_ama_non_aod_hearing_data.rb b/db/seeds/demo_ama_non_aod_hearing_data.rb
index f900f0026fb..2269b59c63e 100644
--- a/db/seeds/demo_ama_non_aod_hearing_data.rb
+++ b/db/seeds/demo_ama_non_aod_hearing_data.rb
@@ -45,7 +45,7 @@ def random_demo_file_number_and_participant_id
     end
 
     def find_or_create_demo_seed_judge(judge_ccs_id)
-      unless judge_ccs_id.empty?
+      unless judge_ccs_id.nil?
         User.find_by_css_id(judge_ccs_id) ||
           create(:user, :judge, :with_vacols_judge_record, css_id: judge_ccs_id, full_name: "Demo Judge " + judge_ccs_id)
       else
diff --git a/db/seeds/demo_direct_reviews_data.rb b/db/seeds/demo_direct_reviews_data.rb
index 99b267789d1..af734bce735 100644
--- a/db/seeds/demo_direct_reviews_data.rb
+++ b/db/seeds/demo_direct_reviews_data.rb
@@ -21,6 +21,8 @@ def create_ama_direct_review
         :appeal,
         :direct_review_docket,
         :ready_for_distribution,
+        :tied_to_judge,
+        tied_judge: @associated_judge,
         associated_judge: @associated_judge,
         veteran: create_demo_veteran_for_docket,
         receipt_date: @days_ago
@@ -42,7 +44,7 @@ def random_demo_file_number_and_participant_id
     end
 
     def find_or_create_demo_seed_judge(judge_ccs_id)
-      unless judge_ccs_id.empty?
+      unless judge_ccs_id.nil?
         User.find_by_css_id(judge_ccs_id) ||
           create(:user, :judge, :with_vacols_judge_record, css_id: judge_ccs_id, full_name: "Demo Judge " + judge_ccs_id)
       else
diff --git a/db/seeds/demo_legacy_cases_data.rb b/db/seeds/demo_legacy_cases_data.rb
index ed92f6b8099..2e4f55601b2 100644
--- a/db/seeds/demo_legacy_cases_data.rb
+++ b/db/seeds/demo_legacy_cases_data.rb
@@ -69,7 +69,7 @@ def random_demo_file_number_and_participant_id
     end
 
     def find_or_create_demo_seed_judge(judge_ccs_id)
-      unless judge_ccs_id.empty?
+      unless judge_ccs_id.nil?
         User.find_by_css_id(judge_ccs_id) ||
           create(:user, :judge, :with_vacols_judge_record, css_id: judge_ccs_id, full_name: "Demo Judge " + judge_ccs_id)
       else