From da704222c84cd10c5522d8fc533429a4a8fc235e Mon Sep 17 00:00:00 2001 From: Eric Tillberg Date: Wed, 23 Oct 2024 11:58:47 -0400 Subject: [PATCH 1/2] Add silent_failure_avoided_no_confirmation StatsD for Simple Forms --- app/models/form_submission_attempt.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/models/form_submission_attempt.rb b/app/models/form_submission_attempt.rb index 0b8e6a455cc..f19c66fac27 100644 --- a/app/models/form_submission_attempt.rb +++ b/app/models/form_submission_attempt.rb @@ -33,6 +33,8 @@ class FormSubmissionAttempt < ApplicationRecord form_type: form_submission.form_type }) simple_forms_enqueue_result_email(:error) + tags = ['service:veteran-facing-forms', "function:#{form_id} form submission to Lighthouse"] + StatsD.increment('silent_failure_avoided_no_confirmation', tags:) end end From 02cc9284da6c57b667940d46967551f3941a40f6 Mon Sep 17 00:00:00 2001 From: Eric Tillberg Date: Wed, 23 Oct 2024 12:51:36 -0400 Subject: [PATCH 2/2] small fix --- app/models/form_submission_attempt.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/models/form_submission_attempt.rb b/app/models/form_submission_attempt.rb index f19c66fac27..e3df4235da7 100644 --- a/app/models/form_submission_attempt.rb +++ b/app/models/form_submission_attempt.rb @@ -26,14 +26,15 @@ class FormSubmissionAttempt < ApplicationRecord event :fail do after do if should_send_simple_forms_email + form_type = form_submission.form_type Rails.logger.info({ message: 'Preparing to send Form Submission Attempt error email', form_submission_id:, benefits_intake_uuid: form_submission.benefits_intake_uuid, - form_type: form_submission.form_type + form_type: }) simple_forms_enqueue_result_email(:error) - tags = ['service:veteran-facing-forms', "function:#{form_id} form submission to Lighthouse"] + tags = ['service:veteran-facing-forms', "function:#{form_type} form submission to Lighthouse"] StatsD.increment('silent_failure_avoided_no_confirmation', tags:) end end