From 6f27411c52741769c67305f6fb35df71ae611415 Mon Sep 17 00:00:00 2001 From: Eric Tillberg Date: Thu, 24 Oct 2024 13:56:01 -0400 Subject: [PATCH 1/3] Make 26-4555 no longer need an ICN to go to the SAHSHA API --- .../controllers/simple_forms_api/v1/uploads_controller.rb | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/modules/simple_forms_api/app/controllers/simple_forms_api/v1/uploads_controller.rb b/modules/simple_forms_api/app/controllers/simple_forms_api/v1/uploads_controller.rb index ba16931016e..f8c68cea126 100644 --- a/modules/simple_forms_api/app/controllers/simple_forms_api/v1/uploads_controller.rb +++ b/modules/simple_forms_api/app/controllers/simple_forms_api/v1/uploads_controller.rb @@ -34,7 +34,7 @@ def submit response = if intent_service.use_intent_api? handle_210966_authenticated - elsif form_is264555_and_should_use_lgy_api + elsif params[:form_number] == '26-4555' handle264555 else submit_form_to_benefits_intake @@ -213,10 +213,6 @@ def perform_pdf_upload(location, file_path, metadata, form) lighthouse_service.perform_upload(**upload_params) end - def form_is264555_and_should_use_lgy_api - params[:form_number] == '26-4555' && icn - end - def icn @current_user&.icn end From 0a43d688b8fcb1826e7556206afcb9f692e4d859 Mon Sep 17 00:00:00 2001 From: Eric Tillberg Date: Fri, 25 Oct 2024 07:59:01 -0400 Subject: [PATCH 2/3] add a test --- .../simple_forms_api/v1/simple_forms_spec.rb | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb b/modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb index c4d5bf8145e..dbda655b223 100644 --- a/modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb +++ b/modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb @@ -4,6 +4,7 @@ require 'simple_forms_api_submission/metadata_validator' require 'common/file_helpers' require 'lighthouse/benefits_intake/service' +require 'lgy/service' RSpec.describe 'SimpleFormsApi::V1::SimpleForms', type: :request do forms = [ @@ -346,6 +347,31 @@ end end + context 'going to SAHSHA API' do + let(:reference_number) { 'some-reference-number' } + let(:body_status) { 'ACCEPTED' } + let(:body) { { 'reference_number' => reference_number, 'status' => body_status } } + let(:status) { 200 } + let(:lgy_response) { double(body:, status:) } + + before do + sign_in + allow_any_instance_of(LGY::Service).to receive(:post_grant_application).and_return(lgy_response) + end + + it 'calls LGY::Service' do + fixture_path = Rails.root.join('modules', 'simple_forms_api', 'spec', 'fixtures', 'form_json', + 'vba_26_4555.json') + data = JSON.parse(fixture_path.read) + + post '/simple_forms_api/v1/simple_forms', params: data + + expect(response).to have_http_status(:ok) + expect(JSON.parse(response.body)['reference_number']).to eq reference_number + expect(JSON.parse(response.body)['status']).to eq body_status + end + end + describe 'failed requests scrub PII from error messages' do before do sign_in From e0e4cf518a95293bd36bd089abba403d1a362658 Mon Sep 17 00:00:00 2001 From: Eric Tillberg Date: Fri, 25 Oct 2024 08:01:48 -0400 Subject: [PATCH 3/3] small test refactor --- .../spec/requests/simple_forms_api/v1/simple_forms_spec.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb b/modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb index dbda655b223..719216ed49f 100644 --- a/modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb +++ b/modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb @@ -359,7 +359,7 @@ allow_any_instance_of(LGY::Service).to receive(:post_grant_application).and_return(lgy_response) end - it 'calls LGY::Service' do + it 'makes the request to LGY::Service' do fixture_path = Rails.root.join('modules', 'simple_forms_api', 'spec', 'fixtures', 'form_json', 'vba_26_4555.json') data = JSON.parse(fixture_path.read) @@ -367,8 +367,9 @@ post '/simple_forms_api/v1/simple_forms', params: data expect(response).to have_http_status(:ok) - expect(JSON.parse(response.body)['reference_number']).to eq reference_number - expect(JSON.parse(response.body)['status']).to eq body_status + parsed_body = JSON.parse(response.body) + expect(parsed_body['reference_number']).to eq reference_number + expect(parsed_body['status']).to eq body_status end end