Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop: incorrect output #26

Open
linsalrob opened this issue Aug 12, 2022 · 0 comments
Open

Develop: incorrect output #26

linsalrob opened this issue Aug 12, 2022 · 0 comments

Comments

@linsalrob
Copy link
Collaborator

The develop branch has two output errors:

  1. Genbank files (printed to STDOUT) occasionally contain an additional line of the format:
92033_gap 92355_gap
  1. fasta files (whether to STDOUT or to a file) crash with the error:
  File "/home/edwa0468/GitHubs/PHANOTATE/venv/lib/python3.9/site-packages/phanotate-2.0-py3.9-linux-x86_64.egg/phanotate/file_handling.py", line 157, in write_fasta   
    if(feature.type == 'CDS'):
AttributeError: 'NoneType' object has no attribute 'type'

There is an additional gap object added to the record which is not a CDS, and so the code

feature = contig_orfs.get_feature(left, right)

returns None

For (1), these are printed (line 126, file_handling.py and for (2) the None is not handled correctly at lines 155-157, file_handling.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant