Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to add new plots/tables #154

Open
dhmay opened this issue Jun 27, 2023 · 2 comments
Open

Make it easier to add new plots/tables #154

dhmay opened this issue Jun 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@dhmay
Copy link
Owner

dhmay commented Jun 27, 2023

Right now, adding a new plot or table isn't very easy or intuitive for a coder who isn't me.

I should add JamstatsPlot and JamstatsTable base classes, make all the existing plots and tables into subclasses of those base classes, and make it easy to add new plots/tables and control what gets displayed.

That last part should apply both to the web interface and to the pdf generation.

@dhmay dhmay added the enhancement New feature or request label Jun 27, 2023
@dhmay
Copy link
Owner Author

dhmay commented Jun 28, 2023

@erevrav Thinking of you!

@dhmay
Copy link
Owner Author

dhmay commented Jul 2, 2023

@erevrav , I've done a mountain of refactoring to clean up the way plots and tables are defined, so that it's easier to add a new plot or table.

I need to communicate to you how to work with this interface, and we may want to make some more tweaks. But my number 1 priority is making sure that, in the process of all of this, I haven't caused regressions in any of the existing functionality. I need to carefully validate all three types of JamStats outputs: PDFs, the web interface, and the webserver interface.

I'd appreciate some help with this! Please check out the build here:

https://github.com/dhmay/jamstats/actions/runs/5435027352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant