From 93885ad701a51e66ec0a05508f8bac751f3d4467 Mon Sep 17 00:00:00 2001 From: agis Date: Thu, 24 Aug 2023 08:46:40 +0700 Subject: [PATCH 1/4] create test checklist keys --- .../report-generator/report-generator.test.ts | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/src/service/report-generator/report-generator.test.ts b/src/service/report-generator/report-generator.test.ts index ae5e5a5..29b874f 100644 --- a/src/service/report-generator/report-generator.test.ts +++ b/src/service/report-generator/report-generator.test.ts @@ -8,13 +8,13 @@ describe('checklist id resolver test', () => { it('should generate report properly', function () { const submissionRequirement = getSubmissionRequirement() - submissionRequirement.API_CAN_DELETE_BOOK.status = true - submissionRequirement.API_CAN_UPDATE_BOOK.status = true - submissionRequirement.API_CAN_GET_DETAIL_BOOK.status = true - submissionRequirement.API_CAN_GET_ALL_BOOK.status = true - submissionRequirement.API_CAN_INSERT_BOOK.status = true - submissionRequirement.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status = true - submissionRequirement.PROJECT_HAVE_CORRECT_PORT.status = true + submissionRequirement.api_can_delete_book.status = true + submissionRequirement.api_can_update_book.status = true + submissionRequirement.api_can_get_detail_book.status = true + submissionRequirement.api_can_get_all_book.status = true + submissionRequirement.api_can_insert_book.status = true + submissionRequirement.project_have_correct_runner_script.status = true + submissionRequirement.project_have_correct_port.status = true const reviewResult: ReviewResult = { @@ -29,14 +29,15 @@ describe('checklist id resolver test', () => { const result = JSON.parse(fs.readFileSync('./test/student/review-result/report.json').toString())[0] - expect(result.checklist.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.checklistId).toStrictEqual(2) - expect(result.checklist.PROJECT_HAVE_CORRECT_PORT.checklistId).toStrictEqual(1) - expect(result.checklist.API_CAN_INSERT_BOOK.checklistId).toStrictEqual(3) - expect(result.checklist.API_CAN_GET_ALL_BOOK.checklistId).toStrictEqual(4) - expect(result.checklist.API_CAN_GET_DETAIL_BOOK.checklistId).toStrictEqual(5) - expect(result.checklist.API_CAN_UPDATE_BOOK.checklistId).toStrictEqual(6) - expect(result.checklist.API_CAN_DELETE_BOOK.checklistId).toStrictEqual(7) - expect(result.checklist_completed).toEqual([1, 2, 3, 4, 5, 6, 7]) + expect(result.checklist_keys).toEqual([ + "project_have_correct_port", + "project_have_correct_runner_script", + "api_can_insert_book", + "api_can_get_all_book", + "api_can_get_detail_book", + "api_can_update_book", + "api_can_delete_book" + ]) expect(result.message).toStrictEqual('

Hallo snder12, terima kasih telah sabar menunggu. Kami membutuhkan waktu untuk bisa memberikan feedback sekomprehensif mungkin kepada setiap peserta kelas. Dalam kesempatan ini ada  4 (empat) hal yang ingin kami sampaikan. 

Pertama, kami ingin mengucapkan selamat! Karena kamu telah menyelesaikan tugas submission dari kelas Belajar Membuat Aplikasi Back-End untuk Pemula. Jangan lihat bintang yang kamu raih, tapi lihat kemajuan yang sudah kamu capai. Ingat semua expert dahulu pemula. 

Kedua, kamu boleh bangga karena telah menyelesaikan submission sesuai dengan kriteria yang telah kami tentukan. Mumpung masih hangat semangatnya langsung lanjut kelas selanjutnya yaitu Architecting on AWS (Membangun Arsitektur AWS di Cloud) atau Belajar Fundamental Aplikasi Back-End. 

Ketiga, beberapa lulusan tidak tahu mereka memiliki akses kelas selamanya. Sebagai informasi kelas Dicoding selalu update sehingga memiliki perbedaan minimal 30% dari sejak kelas dirilis. Silakan mampir kembali untuk melihat materi saat kamu membutuhkan update. 

Keempat, karena sudah praktik langsung maka kamu sudah menguasai ilmu kelas dasar ini antara 75-90%. Salah satu cara agar meningkatkan penguasaan ilmu agar bisa lebih maksimal (>90%) adalah dengan memperbanyak latihan atau mengajarkan ilmu kepada orang lain.

Salah satu misi Dicoding adalah menyebarkan ilmu yang bermanfaat. Kami berusaha membangun kurikulum standar global dengan harapan agar developer Indonesia bisa menjadi jawara di negeri sendiri. Namun misi ini tidak akan tercapai tanpa kolaborasi dari kita semua.

Supaya aplikasimu menjadi lebih baik lagi, berikut beberapa catatan terkait submission kamu:

Silakan berkunjung ke academy discussion untuk mengasah penguasaan ilmu kamu dan membuat ilmu yang kamu dapatkan bisa semakin berkah dan bermanfaat dengan membantu kawan-kawan kita yang saat ini masih berjuang.

Terima kasih telah membantu misi kami. Kesuksesan developer Indonesia adalah energi bagi kami. Jika memiliki pertanyaan atau saran terkait kelas, silakan email ke academy@dicoding.com.

Salam

Dicoding Reviewer

') }); }) From 312e5d855c9ba46687f11460eab2c8a624a8de43 Mon Sep 17 00:00:00 2001 From: agis Date: Thu, 24 Aug 2023 08:47:03 +0700 Subject: [PATCH 2/4] pass test --- .../report-generator/report-generator.ts | 20 +++++-------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/src/service/report-generator/report-generator.ts b/src/service/report-generator/report-generator.ts index b02a34e..262a5e6 100644 --- a/src/service/report-generator/report-generator.ts +++ b/src/service/report-generator/report-generator.ts @@ -25,7 +25,7 @@ class ReportGenerator { message: this.getReviewMessageWithTemplate(reviewResult, autoReviewConfig), submission_path: submissionPath, checklist: reviewResult.checklist, - checklist_completed: this.getCompletedChecklist(reviewResult, autoReviewConfig) + checklist_keys: this.getCompletedChecklist(reviewResult) }; this.result.push(summary); @@ -37,20 +37,10 @@ class ReportGenerator { raiseDomainEvent('report generated') } - private getCompletedChecklist(reviewResult: ReviewResult, autoReviewConfig){ - if (!autoReviewConfig){ - return [] - } - - Object.keys(reviewResult.checklist).forEach(requirementName => { - const requirement = reviewResult.checklist[requirementName] - requirement.checklistId = requirement.possibleChecklistId - .find(checklistId => autoReviewConfig.checklist_ids?.includes(checklistId)) ?? null - }) + private getCompletedChecklist(reviewResult: ReviewResult) { + return Object.keys(reviewResult.checklist) + .filter(requirementName => reviewResult.checklist[requirementName].status) - return Object.keys(reviewResult.checklist) - .filter(checklistName => reviewResult.checklist[checklistName].status === true && reviewResult.checklist[checklistName].checklistId) - .map(checklistName => reviewResult.checklist[checklistName].checklistId) } getReviewMessageWithTemplate(reviewResult: ReviewResult, autoReviewConfig) { @@ -73,7 +63,7 @@ class ReportGenerator { } - private getAutoReviewConfig(projectPath: string): any|null { + private getAutoReviewConfig(projectPath: string): any | null { const configFilePath = `${projectPath}/auto-review-config.json` if (!existsSync(configFilePath)) { From 4129e9a91582e9fce21b4c2ca3dbb4a5b0a03085 Mon Sep 17 00:00:00 2001 From: agis Date: Thu, 24 Aug 2023 08:47:18 +0700 Subject: [PATCH 3/4] adjust requirement --- src/config/submission-requirement.ts | 63 ++++------------------------ 1 file changed, 7 insertions(+), 56 deletions(-) diff --git a/src/config/submission-requirement.ts b/src/config/submission-requirement.ts index f727d16..30aeede 100644 --- a/src/config/submission-requirement.ts +++ b/src/config/submission-requirement.ts @@ -1,33 +1,12 @@ const submissionRequirements = { - PROJECT_HAVE_CORRECT_PORT: { + project_have_correct_port: { status: false, - possibleChecklistId: [ - 47395, //aws 261 - 42180, //cloudeka 510 - 45840, //google cloud 342, - 1, //test - ], - checklistId: null, }, - PROJECT_HAVE_CORRECT_RUNNER_SCRIPT: { + project_have_correct_runner_script: { status: false, - possibleChecklistId: [ - 47400, //aws 261 - 42185, //cloudeka 510 - 45845, //google cloud 342, - 2, //test - ], - checklistId: null, }, - API_CAN_INSERT_BOOK: { + api_can_insert_book: { status: false, - possibleChecklistId: [ - 47370, //aws 261 - 42155, //cloudeka 510 - 45815, //google cloud 342 - 3, //test - ], - checklistId: null, postmanTestName: 'API dapat menyimpan buku', reason: [], postmanTestRequirements: [ @@ -36,31 +15,17 @@ const submissionRequirements = { '[Mandatory] Add Book with Page Read More Than Page Count' ] }, - API_CAN_GET_ALL_BOOK: { + api_can_get_all_book: { status: false, reason: [], - possibleChecklistId: [ - 47375, //aws 261 - 42160, //cloudeka 510 - 45820, //google cloud 342 - 4, //test - ], - checklistId: null, postmanTestName: 'API dapat menampilkan seluruh buku', postmanTestRequirements: [ '[Mandatory] Get All Books', ] }, - API_CAN_GET_DETAIL_BOOK: { + api_can_get_detail_book: { status: false, reason: [], - possibleChecklistId: [ - 47380, //aws 261 - 42165, //cloudeka 510 - 45825, //google cloud 342 - 5, //test - ], - checklistId: null, postmanTestName: 'API dapat menampilkan detail buku', postmanTestRequirements: [ @@ -68,16 +33,9 @@ const submissionRequirements = { '[Mandatory] Get Detail Books With Invalid Id' ] }, - API_CAN_UPDATE_BOOK: { + api_can_update_book: { status: false, reason: [], - possibleChecklistId: [ - 47385, //aws 261 - 42170, //cloudeka 510 - 45830, //google cloud 342 - 6, //test - ], - checklistId: null, postmanTestName: 'API dapat mengubah data buku', postmanTestRequirements: [ '[Mandatory] Update Book With Complete Data', @@ -86,16 +44,9 @@ const submissionRequirements = { '[Mandatory] Update Book with Invalid Id' ] }, - API_CAN_DELETE_BOOK: { + api_can_delete_book: { status: false, reason: [], - possibleChecklistId: [ - 47390, //aws 261 - 42175, //cloudeka 510 - 45835, //google cloud 342 - 7 //test - ], - checklistId: null, postmanTestName: 'API dapat menghapus buku', postmanTestRequirements: [ From 2fe5d9dfcd459ee373b6c863c00e39781622a4cd Mon Sep 17 00:00:00 2001 From: agis Date: Thu, 24 Aug 2023 08:49:09 +0700 Subject: [PATCH 4/4] refactor checklist --- .../course-submission-acception.test.ts | 18 ++++----- .../submission-criteria-check-factory.test.ts | 38 +++++++++---------- .../submission-criteria-check-factory.ts | 12 +++--- .../submission-project-factory.ts | 2 +- .../submission-project-factory.unit.test.ts | 10 ++--- .../server/server-service.integration.test.ts | 8 ++-- src/service/server/server-service.ts | 2 +- 7 files changed, 45 insertions(+), 45 deletions(-) diff --git a/src/entities/review-result/course-submission-acception/course-submission-acception.test.ts b/src/entities/review-result/course-submission-acception/course-submission-acception.test.ts index 6f5049c..8416813 100644 --- a/src/entities/review-result/course-submission-acception/course-submission-acception.test.ts +++ b/src/entities/review-result/course-submission-acception/course-submission-acception.test.ts @@ -23,13 +23,13 @@ describe('course submission acception test', () => { } const submissionRequirement = getSubmissionRequirement() - submissionRequirement.API_CAN_INSERT_BOOK.status = true - submissionRequirement.API_CAN_UPDATE_BOOK.status = true - submissionRequirement.API_CAN_DELETE_BOOK.status = true - submissionRequirement.API_CAN_GET_ALL_BOOK.status = true - submissionRequirement.API_CAN_GET_DETAIL_BOOK.status = true - submissionRequirement.PROJECT_HAVE_CORRECT_PORT.status = true - submissionRequirement.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status = true + submissionRequirement.api_can_insert_book.status = true + submissionRequirement.api_can_update_book.status = true + submissionRequirement.api_can_delete_book.status = true + submissionRequirement.api_can_get_all_book.status = true + submissionRequirement.api_can_get_detail_book.status = true + submissionRequirement.project_have_correct_port.status = true + submissionRequirement.project_have_correct_runner_script.status = true const courseSubmissionAcception = new CourseSubmissionAcception({ reviewChecklistResult: submissionRequirement @@ -108,11 +108,11 @@ describe('course submission acception test', () => { } } } - + const courseSubmissionAcception = new CourseSubmissionAcception({}, submissionRatingFactory); courseSubmissionAcception.accept() expect(courseSubmissionAcception.rating).toStrictEqual(4) expect(courseSubmissionAcception.messages).toContain('...') }); -}) \ No newline at end of file +}) diff --git a/src/factories/submission-criteria-check/submission-criteria-check-factory.test.ts b/src/factories/submission-criteria-check/submission-criteria-check-factory.test.ts index e87144f..4e1c13c 100644 --- a/src/factories/submission-criteria-check/submission-criteria-check-factory.test.ts +++ b/src/factories/submission-criteria-check/submission-criteria-check-factory.test.ts @@ -5,8 +5,8 @@ import getSubmissionRequirements from "../../config/submission-requirement"; describe('mandatory criteria test', () => { const submissionRequirements = getSubmissionRequirements() - submissionRequirements.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status = true - submissionRequirements.PROJECT_HAVE_CORRECT_PORT.status = true + submissionRequirements.project_have_correct_runner_script.status = true + submissionRequirements.project_have_correct_port.status = true const submissionCriteriaCheckFactory = new SubmissionCriteriaCheckFactory() it('should grouping failed test by criteria and return approval false', function () { @@ -30,12 +30,12 @@ describe('mandatory criteria test', () => { ] const expectedReviewChecklistResult = getSubmissionRequirements() - expectedReviewChecklistResult.PROJECT_HAVE_CORRECT_PORT.status = true - expectedReviewChecklistResult.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status = true - expectedReviewChecklistResult.API_CAN_DELETE_BOOK.status = true - expectedReviewChecklistResult.API_CAN_GET_DETAIL_BOOK.status = true - expectedReviewChecklistResult.API_CAN_UPDATE_BOOK.status = true - expectedReviewChecklistResult.API_CAN_INSERT_BOOK.reason = [ + expectedReviewChecklistResult.project_have_correct_port.status = true + expectedReviewChecklistResult.project_have_correct_runner_script.status = true + expectedReviewChecklistResult.api_can_delete_book.status = true + expectedReviewChecklistResult.api_can_get_detail_book.status = true + expectedReviewChecklistResult.api_can_update_book.status = true + expectedReviewChecklistResult.api_can_insert_book.reason = [ { "name": "[Mandatory] Add Book With Complete Data", "tests": [ @@ -49,7 +49,7 @@ describe('mandatory criteria test', () => { }, ] }] - expectedReviewChecklistResult.API_CAN_GET_ALL_BOOK.reason = [{ + expectedReviewChecklistResult.api_can_get_all_book.reason = [{ "name": "[Mandatory] Get All Books", "tests": [{ "message": "Failed to add book, 404", @@ -70,13 +70,13 @@ describe('mandatory criteria test', () => { expect(submissionCriteriaCheck.approvalStatus).toBeTruthy() const expectedReviewChecklistResult = getSubmissionRequirements() - expectedReviewChecklistResult.API_CAN_INSERT_BOOK.status = true - expectedReviewChecklistResult.API_CAN_GET_ALL_BOOK.status = true - expectedReviewChecklistResult.API_CAN_GET_DETAIL_BOOK.status = true - expectedReviewChecklistResult.API_CAN_UPDATE_BOOK.status = true - expectedReviewChecklistResult.API_CAN_DELETE_BOOK.status = true - expectedReviewChecklistResult.PROJECT_HAVE_CORRECT_PORT.status = true - expectedReviewChecklistResult.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status = true + expectedReviewChecklistResult.api_can_insert_book.status = true + expectedReviewChecklistResult.api_can_get_all_book.status = true + expectedReviewChecklistResult.api_can_get_detail_book.status = true + expectedReviewChecklistResult.api_can_update_book.status = true + expectedReviewChecklistResult.api_can_delete_book.status = true + expectedReviewChecklistResult.project_have_correct_port.status = true + expectedReviewChecklistResult.project_have_correct_runner_script.status = true expect(submissionCriteriaCheck.reviewChecklistResult).toStrictEqual(expectedReviewChecklistResult) }) @@ -85,10 +85,10 @@ describe('mandatory criteria test', () => { const submissionCriteriaCheck = submissionCriteriaCheckFactory.check(submissionRequirements) expect(submissionCriteriaCheck.approvalStatus).toBeFalsy() const expectedReviewChecklistResult = getSubmissionRequirements() - expectedReviewChecklistResult.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status = true - expectedReviewChecklistResult.PROJECT_HAVE_CORRECT_PORT.status = true + expectedReviewChecklistResult.project_have_correct_runner_script.status = true + expectedReviewChecklistResult.project_have_correct_port.status = true expect(submissionCriteriaCheck.reviewChecklistResult).toStrictEqual(expectedReviewChecklistResult) expect(submissionCriteriaCheck.failurePostmanTest).toBeNull() }); -}) \ No newline at end of file +}) diff --git a/src/factories/submission-criteria-check/submission-criteria-check-factory.ts b/src/factories/submission-criteria-check/submission-criteria-check-factory.ts index c609447..fb75b33 100644 --- a/src/factories/submission-criteria-check/submission-criteria-check-factory.ts +++ b/src/factories/submission-criteria-check/submission-criteria-check-factory.ts @@ -8,11 +8,11 @@ class SubmissionCriteriaCheckFactory { public check(submissionRequirements: SubmissionRequirement, failurePostmanTest: Array = null): SubmissionCriteriaCheck{ const postmanRequirements = [ - submissionRequirements.API_CAN_INSERT_BOOK, - submissionRequirements.API_CAN_GET_ALL_BOOK, - submissionRequirements.API_CAN_GET_DETAIL_BOOK, - submissionRequirements.API_CAN_UPDATE_BOOK, - submissionRequirements.API_CAN_DELETE_BOOK + submissionRequirements.api_can_insert_book, + submissionRequirements.api_can_get_all_book, + submissionRequirements.api_can_get_detail_book, + submissionRequirements.api_can_update_book, + submissionRequirements.api_can_delete_book ] postmanRequirements.forEach(postmanRequirement => { @@ -29,4 +29,4 @@ class SubmissionCriteriaCheckFactory { } } -export default SubmissionCriteriaCheckFactory \ No newline at end of file +export default SubmissionCriteriaCheckFactory diff --git a/src/factories/submission-project/submission-project-factory.ts b/src/factories/submission-project/submission-project-factory.ts index 6b60567..f4a478a 100644 --- a/src/factories/submission-project/submission-project-factory.ts +++ b/src/factories/submission-project/submission-project-factory.ts @@ -20,7 +20,7 @@ export default class SubmissionProjectFactory { this.checkRunnerCommandUseNodeCommand(runnerCommand) - submissionRequirement.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status = true + submissionRequirement.project_have_correct_runner_script.status = true domainEvent('project has meet requirement') return { packageJsonContent: this.packageJsonContent, diff --git a/src/factories/submission-project/submission-project-factory.unit.test.ts b/src/factories/submission-project/submission-project-factory.unit.test.ts index 774592d..64eea5a 100644 --- a/src/factories/submission-project/submission-project-factory.unit.test.ts +++ b/src/factories/submission-project/submission-project-factory.unit.test.ts @@ -16,7 +16,7 @@ describe('create submission project test', () => { it('should throw error when project path not contain package.json', function () { expect(() => submissionProjectFactory.create(submissionRequirement, null)) .toThrow(new ProjectErrorException('PATH_NOT_CONTAIN_PACKAGE_JSON')) - expect(submissionRequirement.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status).toBeFalsy() + expect(submissionRequirement.project_have_correct_runner_script.status).toBeFalsy() }); it('should throw error when package.json cannot be parsed', function () { @@ -24,7 +24,7 @@ describe('create submission project test', () => { expect(() => submissionProjectFactory.create(submissionRequirement, './xxxx')) .toThrow(new ProjectErrorException('CANNOT_PARSE_PACKAGE_JSON')) - expect(submissionRequirement.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status).toBeFalsy() + expect(submissionRequirement.project_have_correct_runner_script.status).toBeFalsy() }); @@ -33,7 +33,7 @@ describe('create submission project test', () => { expect(() => submissionProjectFactory.create(submissionRequirement, './xxxx')) .toThrow(new ProjectErrorException('PACKAGE_JSON_NOT_CONTAIN_SCRIPT_PROPERTY')) - expect(submissionRequirement.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status).toBeFalsy() + expect(submissionRequirement.project_have_correct_runner_script.status).toBeFalsy() }); @@ -43,7 +43,7 @@ describe('create submission project test', () => { expect(() => submissionProjectFactory.create(submissionRequirement,'.')) .toThrow(new ProjectErrorException('RUNNER_SCRIPT_NOT_FOUND')) - expect(submissionRequirement.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status).toBeFalsy() + expect(submissionRequirement.project_have_correct_runner_script.status).toBeFalsy() }); @@ -85,7 +85,7 @@ describe('create submission project test', () => { .create(submissionRequirement, '/home/app/1234') expect(submissionProject.packageJsonContent).toStrictEqual({ "scripts": { "start": "node src/index.js" }}) expect(submissionProject.packageJsonPath).toStrictEqual('/home/app/1234') - expect(submissionRequirement.PROJECT_HAVE_CORRECT_RUNNER_SCRIPT.status).toBeTruthy() + expect(submissionRequirement.project_have_correct_runner_script.status).toBeTruthy() }); diff --git a/src/service/server/server-service.integration.test.ts b/src/service/server/server-service.integration.test.ts index 1da794d..b415f2b 100644 --- a/src/service/server/server-service.integration.test.ts +++ b/src/service/server/server-service.integration.test.ts @@ -36,7 +36,7 @@ describe('server service test', () => { // test second sever in same port await expect(server.run(submissionProject, submissionRequirement)).rejects.toThrow(new Error(`Port ${port} is not available`)) - expect(submissionRequirement.PROJECT_HAVE_CORRECT_PORT.status).toBeFalsy() + expect(submissionRequirement.project_have_correct_port.status).toBeFalsy() await killServer(fakeServerPid, port) }); @@ -52,7 +52,7 @@ describe('server service test', () => { const spy = jest.spyOn(container, 'stop'); await expect(container.run(submissionProject, submissionRequirement)).rejects.toThrow(new ProjectErrorException('PORT_NOT_MEET_REQUIREMENT')) await expect(spy).toBeCalled() - expect(submissionRequirement.PROJECT_HAVE_CORRECT_PORT.status).toBeFalsy() + expect(submissionRequirement.project_have_correct_port.status).toBeFalsy() }); @@ -70,7 +70,7 @@ describe('server service test', () => { const response = await axios.get(`http://${host}:${port}`) await expect(response.status).toStrictEqual(200) - expect(submissionRequirement.PROJECT_HAVE_CORRECT_PORT.status).toBeTruthy() + expect(submissionRequirement.project_have_correct_port.status).toBeTruthy() //kill server await container.stop() @@ -92,7 +92,7 @@ describe('server service test', () => { const response = await axios.get(`http://${host}:${port}`) await expect(response.status).toStrictEqual(200) - expect(submissionRequirement.PROJECT_HAVE_CORRECT_PORT.status).toBeTruthy() + expect(submissionRequirement.project_have_correct_port.status).toBeTruthy() await container.stop() diff --git a/src/service/server/server-service.ts b/src/service/server/server-service.ts index 50339ef..b1b268d 100644 --- a/src/service/server/server-service.ts +++ b/src/service/server/server-service.ts @@ -19,7 +19,7 @@ class ServerService { try { await this.validateServerActive(500, 10000) - submissionRequirement.PROJECT_HAVE_CORRECT_PORT.status = true + submissionRequirement.project_have_correct_port.status = true raiseDomainEvent('server started') } catch (e) { const serverErrorHandler = new ServerErrorHandler(this._errorLog, submissionProject)