From 6b8570159fec7439d9bb7908e167f7aa08514e4e Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Mon, 23 Oct 2023 07:54:20 +0800 Subject: [PATCH] DEV: Switch to new `addComposerToolbarPopupMenuOption` plugin API (#19) Why this change? `api.addToolbarPopupMenuOptionsCallback` has been deprecated in https://github.com/discourse/discourse/commit/913fd3a7b392b492f6344102577960a6eada00ce --- .discourse-compatibility | 1 + .../discourse/initializers/insert-jitsi.js | 24 ++++++------------- 2 files changed, 8 insertions(+), 17 deletions(-) diff --git a/.discourse-compatibility b/.discourse-compatibility index 7aafec4..79a09ce 100644 --- a/.discourse-compatibility +++ b/.discourse-compatibility @@ -1,2 +1,3 @@ +< 3.2.0.beta2: 97d4e7b550a62ea494ae38c06992be2b008f3fce 3.1.999: c4633135e5cca5172a853430447a87e36bf5f124 diff --git a/javascripts/discourse/initializers/insert-jitsi.js b/javascripts/discourse/initializers/insert-jitsi.js index 14bff19..b2529f8 100644 --- a/javascripts/discourse/initializers/insert-jitsi.js +++ b/javascripts/discourse/initializers/insert-jitsi.js @@ -79,25 +79,15 @@ export default { ) { // do nothing if limited to staff } else { - api.modifyClass("controller:composer", { - pluginId: "discourse-jitsi", - actions: { - insertJitsiModal() { - showModal("insert-jitsi").setProperties({ - toolbarEvent: this.get("toolbarEvent"), - }); - }, + api.addComposerToolbarPopupMenuOption({ + icon: settings.button_icon, + label: themePrefix("composer_title"), + action: (toolbarEvent) => { + showModal("insert-jitsi").setProperties({ + toolbarEvent, + }); }, }); - - api.addToolbarPopupMenuOptionsCallback(() => { - return { - id: "insert_jitsi_button", - icon: settings.button_icon, - action: "insertJitsiModal", - label: themePrefix("composer_title"), - }; - }); } } else { api.onToolbarCreate((toolbar) => {