You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At my company we've run into issues when TypeError exceptions were silenced inside django-elasticsearch-dsl.
When ES field is targeting model's @property and TypeError is raised within getter, it will be completely hidden as int(attr) will raise ValueError and None will be returned:
We need to remove that TypeError from except clause and figure out an alternative solution. At my company, we've been struggling with this for a while so I can prepare a PR if you agree on this.
Thanks!
The text was updated successfully, but these errors were encountered:
Hi,
At my company we've run into issues when
TypeError
exceptions were silenced insidedjango-elasticsearch-dsl
.When ES field is targeting model's
@property
andTypeError
is raised within getter, it will be completely hidden asint(attr)
will raiseValueError
andNone
will be returned:django-elasticsearch-dsl/django_elasticsearch_dsl/fields.py
Lines 64 to 80 in f6fa886
We need to remove that
TypeError
from except clause and figure out an alternative solution. At my company, we've been struggling with this for a while so I can prepare a PR if you agree on this.Thanks!
The text was updated successfully, but these errors were encountered: