Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement overlays #9

Open
dminca opened this issue Jun 12, 2024 · 4 comments · May be fixed by #12
Open

implement overlays #9

dminca opened this issue Jun 12, 2024 · 4 comments · May be fixed by #12
Assignees
Labels
enhancement New feature or request

Comments

@dminca
Copy link
Owner

dminca commented Jun 12, 2024

Establish a mechanism to perform overlaying.

First struggle I had was with pkgs.vimPlugins.coc-explorer where upstream released a fix ( weirongxu/coc-explorer#586 ) for a critical missing feature and need to bring this over before it gets pushed to nixpkgs

Another candidate is pkgs.kluctl which is an older version in nixpkgs even though I'm using nixpkgs-unstable

On a separate note, if some want to wait until the patches are released to nixpkgs-unstable, a PR must be available, then it can be verified if merged here → https://nixpk.gs/pr-tracker.html?pr=319882

@dminca dminca added the enhancement New feature or request label Jun 12, 2024
@dminca dminca self-assigned this Jun 12, 2024
@dminca
Copy link
Owner Author

dminca commented Jun 17, 2024

@dminca
Copy link
Owner Author

dminca commented Jun 17, 2024

Proposal to use npins for installing vimPlugins

https://github.com/Gerg-L/nvim-flake/blob/master/flake.nix#L125-L132

@dminca
Copy link
Owner Author

dminca commented Jul 5, 2024

🌟 Best guide to follow at current point in time → https://fl42v.github.io/nixos-and-flakes-book-ru/nixpkgs/overlays

dminca added a commit that referenced this issue Jul 6, 2024
* setup repo structure
* configure overlay for 'kluctl' package first; once this works, MVP
  delivered
* since this is the initial commit on this feature, it's obviously
  broken and throwing the following error

```sh
error:
       … while evaluating a branch condition

         at /nix/store/7gmkl9bfx98djaamhym69wkj4r3sh1q6-source/lib/lists.nix:125:9:

          124|       fold' = n:
          125|         if n == len
             |         ^
          126|         then nul

       … while calling the 'length' builtin

         at /nix/store/7gmkl9bfx98djaamhym69wkj4r3sh1q6-source/lib/lists.nix:123:13:

          122|     let
          123|       len = length list;
             |             ^
          124|       fold' = n:

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: function 'anonymous lambda' called without required argument 'pkgs'

       at /nix/store/2cv47br877dpnc9p1cv3x95a27nsidb0-source/overlays/kluctl/default.nix:1:1:

            1| { pkgs, config, lib, ... }:
             | ^
            2|
```

Resolves: #9
Related:
Signed-off-by: Daniel-Andrei Minca <zealous_sterner.0e@icloud.com>
@dminca dminca linked a pull request Jul 6, 2024 that will close this issue
@dminca
Copy link
Owner Author

dminca commented Jul 6, 2024

Got some hints on discord and some searching led me to this piece → https://kevinmacksa.me/post/20240128-nix-develop/

dminca added a commit that referenced this issue Oct 22, 2024
* setup repo structure
* configure overlay for 'kluctl' package first; once this works, MVP
  delivered
* since this is the initial commit on this feature, it's obviously
  broken and throwing the following error

```sh
error:
       … while evaluating a branch condition

         at /nix/store/7gmkl9bfx98djaamhym69wkj4r3sh1q6-source/lib/lists.nix:125:9:

          124|       fold' = n:
          125|         if n == len
             |         ^
          126|         then nul

       … while calling the 'length' builtin

         at /nix/store/7gmkl9bfx98djaamhym69wkj4r3sh1q6-source/lib/lists.nix:123:13:

          122|     let
          123|       len = length list;
             |             ^
          124|       fold' = n:

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: function 'anonymous lambda' called without required argument 'pkgs'

       at /nix/store/2cv47br877dpnc9p1cv3x95a27nsidb0-source/overlays/kluctl/default.nix:1:1:

            1| { pkgs, config, lib, ... }:
             | ^
            2|
```

Resolves: #9
Related:
Signed-off-by: Daniel-Andrei Minca <zealous_sterner.0e@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant