Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow submiting ignored code through info.csv #1606

Closed
rien opened this issue Oct 3, 2024 · 1 comment
Closed

Allow submiting ignored code through info.csv #1606

rien opened this issue Oct 3, 2024 · 1 comment
Assignees

Comments

@rien
Copy link
Member

rien commented Oct 3, 2024

Since #1524 we allow ignoring boilerplate / template code by submitting an ignore file. Fingerprints matching with this file will not count towards plagiarism. This is feature can currently only be activated through the CLI.

By adding a field ignored to the info.csv, we could also activate this functionality in other places where Dolos is used (e.g. the Dolos server).

This requires changing the Dolos#fromCSV function to handle an ignored field. The function should be changed to also return this ignored file in addition to the parsed files.

Since we currently only support single-file submissions, it makes sense to throw an error if multiple ignored files are added, as this is possibly a user error. If we want to make this less strict, this could also be an error, but this is less visible.

@mikaelGusse
Copy link
Collaborator

Added in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants