Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs/spaces issue in tutorials when copy pasting from dojo.io #406

Open
haakym opened this issue Mar 15, 2018 · 1 comment
Open

Tabs/spaces issue in tutorials when copy pasting from dojo.io #406

haakym opened this issue Mar 15, 2018 · 1 comment

Comments

@haakym
Copy link

haakym commented Mar 15, 2018

Hi,

While I have been following the tutorials I have noticed a minor issue when copy/pasting some code snippets. It appears that code snippets that are written explicitly in the markdown (i.e. not via include_codefile) have used tabs as indentation, however, when viewing the same code snippet on dojo.io the indentation is rendered as spaces. So, if copy/pasting a code snippet with this issue when following a tutorial the user will experience tslint errors in the console as the downloadable initial project provided at the beginning of the tutorial includes the "indent": [ true, "tabs" ] tslint setting in tslint.json.

Example:

Tabs:

https://github.com/dojo/dojo.io/edit/master/site/source/tutorials/003_creating_widgets/index.md#L58

Spaces:

https://dojo.io/tutorials/003_creating_widgets/#1 (you'll have to scroll down a bit)

Of course this can be fixed by the user when copy pasting code manually or running an equivalent of convert spaces to tabs in their editor, but perhaps there's a way that this can be easily fixed when the site is being generated requiring one less concern from the user?

@dylans
Copy link
Member

dylans commented Mar 15, 2018

Thanks @haakym, I've noticed the same and it's on my list of annoyances. Thanks for the report, we'll get to this eventually!

@dylans dylans added this to the 2018.04 milestone Mar 19, 2018
@dylans dylans modified the milestones: 2018.04, 2018.05 Apr 11, 2018
@dylans dylans removed this from the 2018.05 milestone Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants