Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TemplateBinder strip trailing slash #57988

Open
1 task done
benjaminpetit opened this issue Sep 20, 2024 · 1 comment
Open
1 task done

TemplateBinder strip trailing slash #57988

benjaminpetit opened this issue Sep 20, 2024 · 1 comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Comments

@benjaminpetit
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When the route is defined as Test/{val1} and val1 is empty, the result is Test (without trailing slash).

Trailing slash do matter in some cases.

Expected Behavior

When the route is defined as Test/{val1} and val1 is empty, the result is Test/ (with trailing slash).

Steps To Reproduce

aspnetcore/src/Http/Routing/test/UnitTests/Template/TemplateBinderTests.cs

Line 60 in 73c82c6

"Test/{val1}",

Exceptions (if any)

No response

.NET Version

8

Anything else?

Related issue: microsoft/reverse-proxy#2531
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 20, 2024
@HugoVG
Copy link

HugoVG commented Sep 30, 2024

currently experiencing this bug with YARP as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjaminpetit @HugoVG