Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asking JIT not to align loops triggers multiple asserts #107319

Open
filipnavara opened this issue Sep 3, 2024 · 5 comments
Open

Asking JIT not to align loops triggers multiple asserts #107319

filipnavara opened this issue Sep 3, 2024 · 5 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@filipnavara
Copy link
Member

Try to compile code on ARM64 with JitAlignLoopBoundary=4 option. At least three different asserts are hit.

assert(emitLastIns->idIns() == INS_align);

assert(markedLastLoop && markedCurrLoop);

and one more that can be suppressed with JitHideAlignBehindJmp=0. I forgot the exact location.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 3, 2024
@EgorBo
Copy link
Member

EgorBo commented Sep 3, 2024

сс @kunalspathak @amanasifkhalid

@kunalspathak
Copy link
Member

JitAlignLoopBoundary was an experimental config that was part of non-adaptive loop alignment and is untested.

@kunalspathak
Copy link
Member

Is there a specific scenario where you are not seeing the desired alignment and hence trying out loop boundary option?

@filipnavara
Copy link
Member Author

Is there a specific scenario where you are not seeing the desired alignment and hence trying out loop boundary option?

I was not aware of the JitAlignLoops=0 option and I tried to disable alignment to test the scenario in #107284.

@JulieLeeMSFT JulieLeeMSFT added this to the Future milestone Sep 5, 2024
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Sep 5, 2024
@kunalspathak
Copy link
Member

@filipnavara are you unblocked or do you want anything out of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

4 participants