From 987bb590be7e03ba6cb968d42ed52a6282aa9d7a Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Fri, 25 Oct 2024 11:56:05 -0700 Subject: [PATCH 1/2] Gather test diag logging to track down nuget issue We're seeing NU3003 for packages that when downloaded manually, don't show an issue. Per NuGet team, this means an exception is thrown and collecting verbosity information should help. I believe I've mostly seen this on windows so let's enable for windows and just keep rerunning until we hit it. --- build/RunTestsOnHelix.cmd | 1 + 1 file changed, 1 insertion(+) diff --git a/build/RunTestsOnHelix.cmd b/build/RunTestsOnHelix.cmd index f55fcf1ead42..11f87e1114b4 100644 --- a/build/RunTestsOnHelix.cmd +++ b/build/RunTestsOnHelix.cmd @@ -23,6 +23,7 @@ mkdir %TestExecutionDirectory% REM https://stackoverflow.com/a/7487697/294804 robocopy %HELIX_CORRELATION_PAYLOAD%\t\TestExecutionDirectoryFiles %TestExecutionDirectory% /s /nfl /ndl /njh /njs /np +set Verbosity=diagnostic set DOTNET_SDK_TEST_EXECUTION_DIRECTORY=%TestExecutionDirectory% set DOTNET_SDK_TEST_MSBUILDSDKRESOLVER_FOLDER=%HELIX_CORRELATION_PAYLOAD%\r set DOTNET_SDK_TEST_ASSETS_DIRECTORY=%TestExecutionDirectory%\TestAssets From 6ecb683fde39b96859ac67096ac3ca4669b017d2 Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Fri, 25 Oct 2024 15:47:34 -0700 Subject: [PATCH 2/2] Add diagnostic verbosity to all msbuild commands. Test output is going to be long. --- build/RunTestsOnHelix.cmd | 1 - test/Microsoft.NET.TestFramework/Commands/MSBuildCommand.cs | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/build/RunTestsOnHelix.cmd b/build/RunTestsOnHelix.cmd index 11f87e1114b4..f55fcf1ead42 100644 --- a/build/RunTestsOnHelix.cmd +++ b/build/RunTestsOnHelix.cmd @@ -23,7 +23,6 @@ mkdir %TestExecutionDirectory% REM https://stackoverflow.com/a/7487697/294804 robocopy %HELIX_CORRELATION_PAYLOAD%\t\TestExecutionDirectoryFiles %TestExecutionDirectory% /s /nfl /ndl /njh /njs /np -set Verbosity=diagnostic set DOTNET_SDK_TEST_EXECUTION_DIRECTORY=%TestExecutionDirectory% set DOTNET_SDK_TEST_MSBUILDSDKRESOLVER_FOLDER=%HELIX_CORRELATION_PAYLOAD%\r set DOTNET_SDK_TEST_ASSETS_DIRECTORY=%TestExecutionDirectory%\TestAssets diff --git a/test/Microsoft.NET.TestFramework/Commands/MSBuildCommand.cs b/test/Microsoft.NET.TestFramework/Commands/MSBuildCommand.cs index 73f3416ea8f8..178966a6888f 100644 --- a/test/Microsoft.NET.TestFramework/Commands/MSBuildCommand.cs +++ b/test/Microsoft.NET.TestFramework/Commands/MSBuildCommand.cs @@ -133,6 +133,8 @@ public override CommandResult Execute(IEnumerable args) args = new[] { "/restore" }.Concat(args); } + args = args.Concat(new[] { "-v:diag" }); + return base.Execute(args); }