Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upgrade to bevy 0.14 #22

Open
dc740 opened this issue Jul 17, 2024 · 1 comment · May be fixed by #23
Open

Cannot upgrade to bevy 0.14 #22

dc740 opened this issue Jul 17, 2024 · 1 comment · May be fixed by #23

Comments

@dc740
Copy link

dc740 commented Jul 17, 2024

I gave it a quick try, because it's reaaaally easy -just replace app.world by app.world() and app.world_mut()- but then bevy_pixels stops compiling.

From what I could gather, pixels uses a very old winit (0.28), and for some reason it's OK with bevy 0.13, where you added 0.29 with specific features, but it's no longer the case after moving to bevy 0.14.

There are a lot of compilation errors claiming

...the trait `HasRawDisplayHandle` is not implemented for `WindowWrapper<winit...

Which makes sense, since that it deprecated and HasDisplayHandle should be used instead: https://docs.rs/raw-window-handle/latest/raw_window_handle/trait.HasRawDisplayHandle.html

I'm not entirely sure this is the cause of the conflict, but to me it looks like pixels needs to be updated, so bevy_pixels can also be updated.

I can provide a patch for the version bump, I reverted my local branch to 0.13, but it's really a 5 minute change.

EDIT:
Looks like the story is way more complex:
parasyte/pixels#379
parasyte/pixels#292
there is also raw-window-handle, which is the real reason why pixels can no longer compile, because it's a shared dependency between pixels and winit. So, if winit bumps the version, then pixels needs to bump the version, and bevy_pixels is only working thanks to the workaround on 0.29 that was also used here: parasyte/pixels#379 (comment)

@waynevanson
Copy link

waynevanson commented Sep 6, 2024

I created a new repository for to learn bevy and am on bevy@0.14.1 and came across this issue.

So we need to have matching versions of raw-window-handle between bevy, pixels, and bevy_pixels, is that correct?

If so, we need rwh_06 feature in winit compatible across all three because this dependency seems to be here in bevy_winit

To me it seems this PR is our only blocker.

Never thought I'd bump into you online too @dtcristo 😄

@waynevanson waynevanson linked a pull request Sep 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants