Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyboardInterrupt tests failing on py39, macOS #175

Open
randomir opened this issue Dec 8, 2020 · 3 comments
Open

KeyboardInterrupt tests failing on py39, macOS #175

randomir opened this issue Dec 8, 2020 · 3 comments

Comments

@randomir
Copy link
Member

randomir commented Dec 8, 2020

Failing tests: test_lib.test_headless_interrupt and test_lib.test_interactive_interrupt.

See test-osx-3.9.
@randomir
Copy link
Member Author

randomir commented Dec 8, 2020 •
edited
Loading

@boothby, would you prefer we keep shaving that yak (from 6dcee69, test_lib.py#L855-L884), exclude osx-3.9, or remove kbd int tests altogether?

randomir added a commit to randomir/minorminer that referenced this issue Dec 9, 2020
@randomir
Skip keyboard interrupt tests on macOS + py39
e7acfd3 
Reason for failures is not clear, but it's probably related to signal
handling in lower-level libraries. Deeper investigation is required, and
expected to close dwavesystems#175.
@randomir randomir mentioned this issue Dec 9, 2020
Merged
randomir added a commit that referenced this issue Dec 9, 2020
@randomir
Skip keyboard interrupt tests on macOS + py39 (#176)
6832264 
Reason for failures is not clear, but it's probably related to signal
handling in lower-level libraries. Deeper investigation is required,
but left for #175.
@randomir
Copy link
Member Author

randomir commented Dec 9, 2020

To unblock the release, I patched these tests to skip on osx-py39 as well. That means we're now testing for keyboard interruptibility only on Linux and macOS py35-py37.

This issue is to be closed when a proper fix is implemented.

@boothby
Copy link
Collaborator

boothby commented Dec 9, 2020

That's best for now. I would like to get to the bottom of this, but I've been busy with design work.

@boothby boothby mentioned this issue May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@randomir @boothby