Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bisclique cache location more configurable #242

Open
arcondello opened this issue Jan 25, 2024 · 2 comments
Open

Make bisclique cache location more configurable #242

arcondello opened this issue Jan 25, 2024 · 2 comments

Comments

@arcondello
Copy link
Member

Currently a user can override the cache location, but it's pretty inelegant

import os 

import minorminer.busclique

def myfileloc(version=None):
    dir_path = os.path.dirname(os.path.realpath(__file__))
    return os.path.join(dir_path, "clique_cache")
minorminer.busclique.busgraph_cache.cache_rootdir = myfileloc

it would be nice to have an official API for specifying the cache location

@randomir
Copy link
Member

I agree. Moreover, it would be nice to have consistent cache interface(s) across the whole Ocean. Some preliminary cache control improvements have been done in dwavesystems/dwave-cloud-client#579, but they don't cover on-disk cache control.

@boothby
Copy link
Collaborator

boothby commented Jan 25, 2024

I agree, @randomir. The disk cache I wrote here is entirely out of place, I hate just about every line of it, and I do not want to continue maintaining it if at all possible. If a better solution exists (I've only perused the bullet points of https://pypi.org/project/diskcache/ but it looks perfect) we should use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants