Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add checks against known checkfiles for pushed code #47

Open
nilslice opened this issue May 5, 2023 · 2 comments
Open

ci: add checks against known checkfiles for pushed code #47

nilslice opened this issue May 5, 2023 · 2 comments
Assignees
@wikiwong @nilslice

Comments

@nilslice
Copy link
Member

nilslice commented May 5, 2023 •
edited by neuronicnobody
Loading

Currently, the CI workflows only "test" that the checked in checkfiles still work against the latest published GitHub Action. Not that the actual code in this repo works against any tests when PRs are created.

We need to at minimum run cargo run -- validate ... against these checkfiles, so that we're doing a test against the changed code in the PR.
@neuronicnobody
Copy link
Contributor

@nilslice please add more info

@nilslice
Copy link
Member Author

Currently, the CI workflows only "test" that the checked in checkfiles still work against the latest published GitHub Action. Not that the actual code in this repo works against any tests when PRs are created.

We need to at minimum run cargo run -- validate ... against these checkfiles, so that we're doing a test against the changed code in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wikiwong wikiwong

@nilslice nilslice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neuronicnobody @wikiwong @nilslice