Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create script to update biome_defaults.csv from ForC #121

Open
teixeirak opened this issue Nov 15, 2018 · 6 comments
Open

create script to update biome_defaults.csv from ForC #121

teixeirak opened this issue Nov 15, 2018 · 6 comments
Assignees
Milestone

Comments

@teixeirak
Copy link
Contributor

I'd like to be able to update biome_defaults based on data from ForC (T1-T12 and S1 only). This should be an easy task for @ValentineHerr once I provide instructions, which is the next step.

@teixeirak teixeirak self-assigned this Nov 15, 2018
@teixeirak teixeirak added this to the Publication milestone Mar 14, 2019
@ValentineHerr
Copy link
Contributor

See results here

@teixeirak
Copy link
Contributor Author

Thanks! Next step is for me to give this a careful review.

@teixeirak
Copy link
Contributor Author

teixeirak commented Oct 15, 2019

Here are some things to fix (running list):

  • these numbers appear to be in units of C (not sure why-- I know you had a line to convert to OM in the code).
  • there are some sites with NA in calculatior_Biome. Why?
  • in the previous iteration, we had to allow inclusion of some younger forests (several biome/ variable combinations) and managed sites in order to have sufficient data (see screenshot below). We'll need to do that for a few here (KAT-specify!).

Screen Shot 2019-10-15 at 6 40 20 AM

List is not yet complete; please wait until I finish.

@teixeirak
Copy link
Contributor Author

@ValentineHerr - An update: I have created this Matlab script to update biome_defaults. I think its best for me to write this script because there are so many variables and biomes, including many outside the realm of ForC, and frequent need to make decisions as to how to assign values to biomes.

I think I would like to have your script creating data_used_to_calculate_biome_defaults.csv, which I will then draw on in my script.

Next step is for me to provide an updated list on what needs to be modified in data_used_to_calculate_biome_defaults.csv.

@ValentineHerr
Copy link
Contributor

Ok @teixeirak, I'll wait on your list.
This is the link to the R script you are talking about (just to have it handy in this thread):
https://github.com/forc-db/ForC/blob/master/scripts/for_calculator/Calculate_Biome_defaults.R

@teixeirak
Copy link
Contributor Author

Okay, here's the start of a list:

  • these numbers appear to be in units of C, as opposed to OM. I'm not sure what's going on, as it looks like you convert it here in the script
  • there are some sites with NA or something like tropical/subtropical in calculatior_Biome. Why? Are these missing the required info?

We'll also want to record some additional info in data_used_to_calculate_biome_defaults, noting that I'll eventually want to make it compatible with this file (although I'll likely modify fields in that file). I'll provide more on this and other items soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants