You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A contributor, not me, submits a high quality PR with their awesome board game. They used the web editor and missed a single character (some small amount of variance) causing the linter to complain and block the PR. This is 💩, since it's 99% awesome.
Why This Is Needed
My previous attempt (#62) worked well on master in this repo, but wasn't able to handle PRs as gracefully as desired. In short, it would require formatter/linting checking _after merging into master, causing additional commits. This is inefficient with the pattern of git and GH PRs, as we're meant to detect and address this stuff before merging.
The text was updated successfully, but these errors were encountered:
TL;DR: this doesn't seem easily done, especially not for while the code is within a forked (non-source) repo
Longer:
Formatting the code during the PR can't commit "back" to a non-source (forked) repo. Git hooks won't work as the use case here is generally using GitHub's editor in-browser, which just isn't going to happen.
TL;DR: Looking to implement samuelmeuli/lint-action or similar.
Situation
A contributor, not me, submits a high quality PR with their awesome board game. They used the web editor and missed a single character (some small amount of variance) causing the linter to complain and block the PR. This is 💩, since it's 99% awesome.
Why This Is Needed
My previous attempt (#62) worked well on
master
in this repo, but wasn't able to handle PRs as gracefully as desired. In short, it would require formatter/linting checking _after merging intomaster
, causing additional commits. This is inefficient with the pattern of git and GH PRs, as we're meant to detect and address this stuff before merging.The text was updated successfully, but these errors were encountered: