Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No span compression with apmotel #1644

Open
milesich opened this issue Aug 15, 2024 · 1 comment
Open

No span compression with apmotel #1644

milesich opened this issue Aug 15, 2024 · 1 comment
Labels

Comments

@milesich
Copy link

Describe the bug
When apmotel package is imported spans cannot be compressed.

apmotel package override the apm context functions which calls span.TraceContext which marks the trace context as propagated. One of the requirement for a span to be eligible for compression is that the context is not propagated.

To Reproduce
A simple example like the one here with apmotel package imported.

Expected behavior
Spam should be eligible for compression when apmotel package is imported.

@dmathieu
Copy link
Member

There are actually two problems here:

As you mention, apmotel needs to call TraceContext() to properly propagate the span information, which marks the span as having been propagated and prevents compression.
Otel has no notion of "exit spans", so we can't mark OpenTelemetry spans as exit ones, so they will never be elligible for compression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants