-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance ECS logging correlation fields #765
Comments
I think it doesn't hurt mentioning it but there's nothing that agents need to do as they already send the container.id as part of the metadata. The container.id correlation is more relevant when shipping the logs with Filebeat and when there's no service.name within the logs.
+1 on improving the docs to point out how service/log correlation works and how to configure Filebeat or Elastic Agent to add |
I've added a mention of +1 for the documentation part, I will add it to the shopping list in this issue description, same for providing the configuration options to set those fields in the filebeat configuration and maybe in ECS-logging. When the APM agent is combined with ECS-logging library I would recommend to let the agent provide its own values though to avoid inconsistencies. For the fact that Elastic Agent isn't mentioned, I think it would be better handled as a follow-up once this part is done. |
Closing as specs and documentation are complete, implementation in agents is not 100% complete for service environment correlation see #773 for details. |
service.environment
in ECS reformatting: Spec service.environment for logs #766trace.id
,transaction.id
service.name
,service.version
,service.environment
container.id
in the agents specification too ? Yes & no: we can mention it for reference but agents are not expected to set it.service.environment
to ECS logging documentation: https://www.elastic.co/guide/en/ecs-logging/overview/current/intro.html#_configurable_fields : add service.{version,environment} to docs ecs-logging#75Out of scope for now
error.id
when an error is reported in the logs (currently the Java agent creates an error, this feature is currently documented as Error capturing)service.name
,service.environment
andservice.version
to the fields that are automatically injected in MDCs for log correlation: this would allow for example to use those in plain-text logs.span.id
for log correlation.The text was updated successfully, but these errors were encountered: