Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash 1.16.5 #40

Closed
Redls07 opened this issue Mar 14, 2023 · 13 comments
Closed

Crash 1.16.5 #40

Redls07 opened this issue Mar 14, 2023 · 13 comments

Comments

@Redls07
Copy link

Redls07 commented Mar 14, 2023

Mod version 1.10.1

crash-2023-03-14_20.58.12-client.txt
@embeddedt
Copy link
Owner

I think it's an incompatibility with Better Loading Screen, the only way to fix this would be to automatically disable the optimizations on my side if its installed (which would slow down the launch). I'd suggest just not using Better Loading Screen.

@Redls07
Copy link
Author

Redls07 commented Mar 14, 2023

Yeah, tried to run the game without it, and there is no crash. Thank you for the quick response and for your work. Game loading decreased from 2 min 50 sec to 1 min 10 sec

@Redls07 Redls07 closed this as completed Mar 14, 2023
@embeddedt
Copy link
Owner

At some point I'm thinking I will add my own idea of a loading screen directly in ModernFix.

@Redls07
Copy link
Author

Redls07 commented Mar 14, 2023

If it can be disabled in the config, if someone doesn't like it, then why not

@Redls07
Copy link
Author

Redls07 commented Mar 17, 2023

Another crash, this time when trying to create a world
crash-2023-03-17_09.46.55-client.txt

@Redls07 Redls07 reopened this Mar 17, 2023
@embeddedt
Copy link
Owner

Known issue with Dynamic Trees - they have buggy code in their blocks which just so happens to work fine with vanilla. Unfortunately I can't easily fix it from my side.

DynamicTreesTeam/DynamicTrees#758

@embeddedt embeddedt closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2023
@embeddedt
Copy link
Owner

I might tweak ModernFix's caching logic to behave more like vanilla, in order to avoid outright crashes if there is a buggy mod.

@Redls07
Copy link
Author

Redls07 commented Mar 19, 2023

It would be great

@embeddedt
Copy link
Owner

embeddedt commented Mar 20, 2023 via email

@Redls07
Copy link
Author

Redls07 commented Mar 21, 2023

Crash
crash-2023-03-21_16.00.04-client.txt

@embeddedt
Copy link
Owner

This is an incompatibility with Lightspeed that is on my list of things to fix. For now you should just run without Lightspeed; there shouldn't be much performance loss as at the moment, ModernFix implements mostly the same optimizations.

@embeddedt
Copy link
Owner

I just pushed 1.11.1 with a fix; it may take a little bit to get approved on CurseForge.

@Redls07
Copy link
Author

Redls07 commented Mar 21, 2023

Everything works, thanks a lot! 62 seconds with Lightspeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@embeddedt @Redls07