More convenient indexing of array members

[wvengen]

I find EmbedlyObject's behaviour to return nil for non-existent members convenient. It would be even more convenient if (hash and) array members would return an object that behaves in a similar way, so that for example response.images.first.name doesn't give an error when there are no associated images. I would have expected response.images to be something like an EmbedlyObject.

Right now I'm wrapping the response in an object containing something like

class MyEmbedly < SimpleDelegator
  def initialize(url)
    super(url)
  end

  def images
    (super || []).map &OpenStruct.method(:new)
  end

  private

  def data(url)
    @embedly ||= Embedly::API.new key: ENV['EMBEDLY_KEY']
    @data ||= @embedly.extract(url: url).first
  end
end

but believe it could better be solved here.

[dokipen]

Please submit a pull request.
On Oct 23, 2014 11:34 AM, "wvengen" notifications@github.com wrote:

I find EmbedlyObject's behaviour to return nil for non-existent members
convenient. It would be even more convenient if (hash and) array members
would return an object that behaves in a similar way, so that for example
response.images.first.name doesn't give an error when there are no
associated images.

Right now I'm wrapping the response in an object containing something like

class MyEmbedly < SimpleDelegator
def initialize(url)
super(url)
end

def images
(super || []).map &OpenStruct.method(:new)
end

private

def data(url)
@embedly ||= Embedly::API.new key: ENV['EMBEDLY_KEY']
@DaTa ||= @embedly.extract(url: url).first
endend

but believe it could better be solved here.

—
Reply to this email directly or view it on GitHub
#29.

[wvengen]

Good to hear you're open to the idea. I hope to get to this at some point in the future.

[dokipen]

No problem, it's a potentially breaking change, so please add something to the ChangeLog describing it. I'll fill in the version number and date.