Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle protocol message parts in method signatures #48

Open
fjarri opened this issue Oct 28, 2024 · 0 comments
Open

Bundle protocol message parts in method signatures #48

fjarri opened this issue Oct 28, 2024 · 0 comments
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Milestone
v1.0.0

Comments

@fjarri
Copy link
Member

fjarri commented Oct 28, 2024

With #47 in, there is a number of methods taking EchoBroadcast, NormalBroadcast, DirectMessage trio (e.g. Round::receive_message() or the evidence.rs methods). Can we bundle them in one type to reduce noise?
@fjarri fjarri added API Involves backwards-incompatible changes of the public API code quality Making things simpler labels Oct 28, 2024
@fjarri fjarri added this to the v1.0.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@fjarri