From 9cca41d5bb80f0f35fdc70e86c64d9f639e9909a Mon Sep 17 00:00:00 2001 From: Daniel Couzens Date: Tue, 3 Sep 2024 14:15:55 +0100 Subject: [PATCH 1/2] fixes bug --- app/models/step_select_postcode_area.rb | 4 ++-- app/models/step_select_postcode_district.rb | 4 ++-- app/models/step_select_postcode_sector.rb | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/models/step_select_postcode_area.rb b/app/models/step_select_postcode_area.rb index 7f66ba7..1c1fbc4 100644 --- a/app/models/step_select_postcode_area.rb +++ b/app/models/step_select_postcode_area.rb @@ -33,8 +33,8 @@ def validate_with(workflow, value) workflow.traverse_to(successor_step) else set_flash("Sorry, '#{value}' does not appear to be a valid value for a #{subtype_label}. - A #{subtype_label} is the first one or two letters of a UK postcode, for example "B" - or "TA"".html_safe) + A #{subtype_label} is the first one or two letters of a UK postcode, for example + 'B' or 'TA'.") end end end diff --git a/app/models/step_select_postcode_district.rb b/app/models/step_select_postcode_district.rb index d6b1548..2c6a643 100644 --- a/app/models/step_select_postcode_district.rb +++ b/app/models/step_select_postcode_district.rb @@ -33,8 +33,8 @@ def validate_with(workflow, value) workflow.traverse_to(successor_step) else set_flash("Sorry, '#{value}' does not appear to be a valid value for a #{subtype_label}. - A #{subtype_label} is the first part of a UK postcode, up to the space. For example - "B17" or "TA9"".html_safe) + A #{subtype_label} is the first part of a UK postcode, up to the space. For example + 'B17' or 'TA9'.") end end end diff --git a/app/models/step_select_postcode_sector.rb b/app/models/step_select_postcode_sector.rb index d62c9b2..077437e 100644 --- a/app/models/step_select_postcode_sector.rb +++ b/app/models/step_select_postcode_sector.rb @@ -37,8 +37,8 @@ def validate_with(workflow, value) workflow.traverse_to(successor_step) else set_flash("Sorry, '#{value}' does not appear to be a valid value for a #{subtype_label}. - A #{subtype_label} is the first part of a UK postcode, up to and including the first - digit after the space. For example "B17 0" or "TA9 3"".html_safe) + A #{subtype_label} is the first part of a UK postcode, up to and including the first + digit after the space. For example 'B17 0' or 'TA9 3'.") end end end From 168754289cbc25d4e409911935e2a6e9ad5f6e58 Mon Sep 17 00:00:00 2001 From: Daniel Couzens Date: Tue, 3 Sep 2024 14:18:16 +0100 Subject: [PATCH 2/2] updates changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 88d6992..f7bc1e3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,8 @@ # Standard Reports UI: change log -## 1.5.3 - 2024-08 +## 1.5.3 - 2024-09 +- (Dan) Fixes bug XXS vulnerability [133](https://github.com/epimorphics/standard-reports-ui/issues/133) - (Dan) Update the error messages for the postcode selectors step 3/7 so each error message is unique to the postcode selector [120](https://github.com/epimorphics/standard-reports-ui/issues/120) - (Dan) Updates alt text for screenshots of example reports [115](https://github.com/epimorphics/standard-reports-ui/issues/115) - (Dan) Updates report page styles so links are underlined and gives download report page a seperate page title