Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventional commits #28

Open
meowsbits opened this issue Mar 4, 2019 · 1 comment
Open

Conventional commits #28

meowsbits opened this issue Mar 4, 2019 · 1 comment
Labels
discuss Ticket requires more discussion

Comments

@meowsbits
Copy link
Member

meowsbits commented Mar 4, 2019

Is your feature request related to a problem? Please describe.

Currently conventional commits refers and adheres to http://conventionalcommits.org/.

My issue is that this "Conventional commits" style isn't really conventional; it's actually pretty opinionated.

Since the Conventional Commits spec allows arbitrary xxx[yyy]:, it seems like the only thing that structuring a message in this way does is enable easier machine readability1 (and not work directly to Documentation Driven Development in the sense of legible and accurate documentation around development). It's just a punctuation spec, not a content spec, and despite it's name is not very generalized.

Describe the solution you'd like

Something as generic as possible, while still being able to describe something that's actually useful.

In my opinion there are more useful resources we can draw from for outlining a rubric for a "good" commit message, for example

Describe alternatives you've considered

  • scope: message; useful for big repos, not so much for small ones
  • Commit messages should start with a capital letter
  • problem: xxx / solution: yyy structure
  • https://rfc.zeromq.org/spec:44/C4/

Resources

I spent 10 minutes looking through "top starred" repos on Github for examples (for lack of a better "canon of the conventional").

A list of example repos that don't follow this pattern:

Repos I found that do use it:


  1. From the docs, 3/5 of "Why Use Conventional Commits" are for computer automation.
@meowsbits meowsbits added the discuss Ticket requires more discussion label Mar 4, 2019
@triage-new-issues triage-new-issues bot removed the triage label Mar 4, 2019
@BelfordZ
Copy link
Contributor

BelfordZ commented Mar 9, 2019

While you make some very good points, for me, its a hard sell to change to anything else for 1 reason: tooling.

Conventional commit style ATM has the best tooling from what I could see. Basically we need out of the box validation of messages in CI, and ideally changelog generators, etc etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Ticket requires more discussion
Projects
None yet
Development

No branches or pull requests

2 participants