Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ete evol: Incorrect documentation for the b_free - b_neut test #748

Open
lab83bio opened this issue May 9, 2024 · 0 comments
Open

ete evol: Incorrect documentation for the b_free - b_neut test #748

lab83bio opened this issue May 9, 2024 · 0 comments

Comments

@lab83bio
Copy link

lab83bio commented May 9, 2024

Hi,
The ete3 evol documentation is well presented and easy to read. However, I think there are several typos in the explanation of the b_free - b_neut test (ex. here and here):

Alternative Null Test
b_free b_neut foreground branch not neutral (w != 1)
- RX if P<0.05 (means that w on frg=1)
- PS if P>0.05 and wfrg>1
- CN if P>0.05 and wfrg>1
(Ziheng Yang (2002))

I think this should read:

Alternative Null Test
b_free b_neut foreground branch not neutral (w != 1)
- RX if P>0.05 (means that w on frg=1)
- PS if P<0.05 and wfrg>1
- CN if P<0.05 and wfrg<1
(Ziheng Yang (2002))

Also CN (CoNserved?) is not defined. Maybe NS (Negative Selection) would be more intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant